-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when given invalid hosting configuration. #5533
Conversation
} catch (e: any) { | ||
throw new FirebaseError( | ||
"Invalid hosting rewrite config in firebase.json. " + | ||
"A rewrite config must specify 'destination', 'function', 'dynamicLinks', or 'run'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the only list of situations where this can happen? If so, then this should bef ine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
Codecov ReportBase: 56.13% // Head: 56.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5533 +/- ##
=======================================
Coverage 56.13% 56.13%
=======================================
Files 317 317
Lines 21503 21505 +2
Branches 4388 4388
=======================================
+ Hits 12070 12072 +2
- Misses 8370 8371 +1
+ Partials 1063 1062 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Given invalid hosting configuration, Firebase CLI fails in an unhelpful way.
e.g.
Before:
After
Fixes https://groups.google.com/a/google.com/g/firebase-discuss/c/VoQ0XkNnZFs