Use git status to check for changes to devsite #8448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (fa0ed08) and merge commit (7726a2d).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (fa0ed08) and merge commit (7726a2d).Test Logs |
992208a to
89eabf0
Compare
DellaBitta
approved these changes
Aug 21, 2024
hsubox76
approved these changes
Aug 21, 2024
| @@ -36,7 +36,12 @@ jobs: | |||
| - name: Run doc generation | |||
| run: yarn docgen:all | |||
| - name: Check for changes in docs-devsite dir (fail if so) | |||
| run: git diff --exit-code docs-devsite | |||
| run: | | |||
| if [[ -n "$(git status docs-devsite --porcelain)" ]]; then | |||
There was a problem hiding this comment.
What an odd name for a command line option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check did not account for untracked changes, which caused it to output false-positives in two cases.
docs-devsite/was deleted in a previous commit on the PR.yarn docgen:allwill regenerate the deleted file, but since it was previously deleted, it will now be untracked, sogit diff --exit-codewill succeed.yarn docgen:allgenerates a new file, but it doesn't exist in the PR, it will be untracked, sogit diff --exit-codewill succeed.We can fix this by instead exiting with code 1 if
git statushas any output, which will include any untracked changes.