Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and link formatting in contribution guide #8183

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix typo and link formatting in contribution guide #8183

merged 1 commit into from
Apr 22, 2024

Conversation

dlarocque
Copy link
Contributor

  • Fixed 'adn' to 'and'
  • Remove extra right parenthesis in markdown link that caused the link not to be formatted, and the closing parenthensis to be missing

@dlarocque
Fix typo and link formatting in contribution guide
8f6133b 
- Fixed 'adn' to 'and'
- Remove extra right parenthesis in markdown link that caused the link
  not to be formatted, and the closing parenthensis to be missing.
@dlarocque dlarocque requested a review from a team as a code owner April 18, 2024 16:21
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 8f6133b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (399ae5a) and merge commit (1169e45).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZkprDrI2Ma.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (399ae5a) and merge commit (1169e45).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DNWA3QU69m.html

DellaBitta
DellaBitta approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dlarocque dlarocque merged commit 03069bb into master Apr 22, 2024
33 of 36 checks passed
@dlarocque dlarocque deleted the dlarocque/contributing-guide-typo branch April 22, 2024 14:10
@firebase firebase locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlarocque @google-oss-bot @DellaBitta