Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore: Factor out logic that extracts paths from package.json in rollup scripts #7956

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Firestore: Factor out logic that extracts paths from package.json in rollup scripts #7956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a972489
rollup.shared.js: add getPackageJsonExportPaths() function
dconeybe Jan 16, 2024
46e63ea
rollup.shared.js: return a nested structure from getPackageJsonExport…
dconeybe Jan 16, 2024
9c1dadb
rollup.config.js: use getPackageJsonExportPaths() instead of accessin…
dconeybe Jan 16, 2024
bddda9d
rollup.config.lite.js: use getPackageJsonExportPaths() instead of acc…
dconeybe Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions packages/firestore/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ import typescript from 'typescript';

import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';

import pkg from './package.json';

const sourcemaps = require('rollup-plugin-sourcemaps');
const util = require('./rollup.shared');

const outputFiles = util.getPackageJsonExportPaths();

const nodePlugins = function () {
return [
typescriptPlugin({
Expand Down Expand Up @@ -77,7 +77,7 @@ const allBuilds = [
{
input: './src/index.node.ts',
output: {
file: pkg['main-esm'],
file: outputFiles.main.node.import,
format: 'es',
sourcemap: true
},
Expand All @@ -90,9 +90,9 @@ const allBuilds = [
},
// Node CJS build
{
input: pkg['main-esm'],
input: outputFiles.main.node.import,
output: {
file: pkg.main,
file: outputFiles.main.node.require,
format: 'cjs',
sourcemap: true
},
Expand All @@ -107,9 +107,9 @@ const allBuilds = [
},
// Node ESM build with build target reporting
{
input: pkg['main-esm'],
input: outputFiles.main.node.import,
output: {
file: pkg['main-esm'],
file: outputFiles.main.node.import,
format: 'es',
sourcemap: true
},
Expand All @@ -128,7 +128,7 @@ const allBuilds = [
{
input: './src/index.ts',
output: {
file: pkg.browser,
file: outputFiles.main.browser.import,
format: 'es',
sourcemap: true
},
Expand All @@ -140,10 +140,10 @@ const allBuilds = [
},
// Convert es2017 build to ES5
{
input: pkg['browser'],
input: outputFiles.main.browser.import,
output: [
{
file: pkg['esm5'],
file: outputFiles.main.esm5,
format: 'es',
sourcemap: true
}
Expand All @@ -159,7 +159,7 @@ const allBuilds = [
},
// Convert es2017 build to cjs
{
input: pkg['browser'],
input: outputFiles.main.browser.import,
output: [
{
file: './dist/index.cjs.js',
Expand All @@ -178,10 +178,10 @@ const allBuilds = [
},
// es2017 build with build target reporting
{
input: pkg['browser'],
input: outputFiles.main.browser.import,
output: [
{
file: pkg['browser'],
file: outputFiles.main.browser.import,
format: 'es',
sourcemap: true
}
Expand All @@ -199,7 +199,7 @@ const allBuilds = [
{
input: './src/index.rn.ts',
output: {
file: pkg['react-native'],
file: outputFiles.main.rn,
format: 'es',
sourcemap: true
},
Expand Down
28 changes: 14 additions & 14 deletions packages/firestore/rollup.config.lite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/

import tmp from 'tmp';
import path from 'path';
import json from '@rollup/plugin-json';
import alias from '@rollup/plugin-alias';
import typescriptPlugin from 'rollup-plugin-typescript2';
Expand All @@ -25,11 +24,12 @@ import sourcemaps from 'rollup-plugin-sourcemaps';
import replace from 'rollup-plugin-replace';
import { terser } from 'rollup-plugin-terser';

import pkg from './lite/package.json';
import { generateBuildTargetReplaceConfig } from '../../scripts/build/rollup_replace_build_target';

const util = require('./rollup.shared');

const outputFiles = util.getPackageJsonExportPaths();

const nodePlugins = function () {
return [
typescriptPlugin({
Expand Down Expand Up @@ -72,7 +72,7 @@ const allBuilds = [
{
input: './lite/index.ts',
output: {
file: path.resolve('./lite', pkg['main-esm']),
file: outputFiles.lite.node.import,
format: 'es',
sourcemap: true
},
Expand All @@ -91,9 +91,9 @@ const allBuilds = [
},
// Node CJS build
{
input: path.resolve('./lite', pkg['main-esm']),
input: outputFiles.lite.node.import,
output: {
file: path.resolve('./lite', pkg.main),
file: outputFiles.lite.node.require,
format: 'cjs',
sourcemap: true
},
Expand All @@ -117,9 +117,9 @@ const allBuilds = [
},
// Node ESM build
{
input: path.resolve('./lite', pkg['main-esm']),
input: outputFiles.lite.node.import,
output: {
file: path.resolve('./lite', pkg['main-esm']),
file: outputFiles.lite.node.import,
format: 'es',
sourcemap: true
},
Expand All @@ -138,7 +138,7 @@ const allBuilds = [
{
input: './lite/index.ts',
output: {
file: path.resolve('./lite', pkg.browser),
file: outputFiles.lite.browser.import,
format: 'es',
sourcemap: true
},
Expand All @@ -157,10 +157,10 @@ const allBuilds = [
},
// Convert es2017 build to ES5
{
input: path.resolve('./lite', pkg.browser),
input: outputFiles.lite.browser.import,
output: [
{
file: path.resolve('./lite', pkg.esm5),
file: outputFiles.lite.esm5,
format: 'es',
sourcemap: true
}
Expand All @@ -176,7 +176,7 @@ const allBuilds = [
},
// Convert es2017 build to CJS
{
input: path.resolve('./lite', pkg.browser),
input: outputFiles.lite.browser.import,
output: [
{
file: './dist/lite/index.cjs.js',
Expand All @@ -195,10 +195,10 @@ const allBuilds = [
},
// Browser es2017 build
{
input: path.resolve('./lite', pkg.browser),
input: outputFiles.lite.browser.import,
output: [
{
file: path.resolve('./lite', pkg.browser),
file: outputFiles.lite.browser.import,
format: 'es',
sourcemap: true
}
Expand All @@ -216,7 +216,7 @@ const allBuilds = [
{
input: './lite/index.ts',
output: {
file: path.resolve('./lite', pkg['react-native']),
file: outputFiles.lite.rn,
format: 'es',
sourcemap: true
},
Expand Down
80 changes: 80 additions & 0 deletions packages/firestore/rollup.shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,3 +364,83 @@ exports.es2017PluginsCompat = function (
];
}
};

function getPackageJsonExportPaths() {
const {
exports: {
'.': {
types: main_types,
browser: { require: main_browser_require, import: main_browser_import },
node: { require: main_node_require, import: main_node_import },
'react-native': main_react_native,
esm5: main_esm5
},
'./lite': {
types: lite_types,
browser: { require: lite_browser_require, import: lite_browser_import },
node: { require: lite_node_require, import: lite_node_import },
'react-native': lite_react_native,
esm5: lite_esm5
}
}
} = pkg;

const map = new Map();
map.set('main_types', main_types);
map.set('main_browser_require', main_browser_require);
map.set('main_browser_import', main_browser_import);
map.set('main_node_require', main_node_require);
map.set('main_node_import', main_node_import);
map.set('main_react_native', main_react_native);
map.set('main_esm5', main_esm5);
map.set('lite_types', lite_types);
map.set('lite_browser_require', lite_browser_require);
map.set('lite_browser_import', lite_browser_import);
map.set('lite_node_require', lite_node_require);
map.set('lite_node_import', lite_node_import);
map.set('lite_react_native', lite_react_native);
map.set('lite_esm5', lite_esm5);

const missingKeys = [];
map.forEach((value, key) => {
if (!value) {
missingKeys.push(key);
}
});

if (missingKeys.length > 0) {
throw new Error(
'missing keys from package.json: ' + missingKeys.join(', ')
);
}

return {
main: {
types: main_types,
browser: {
require: main_browser_require,
import: main_browser_import
},
node: {
require: main_node_require,
import: main_node_import
},
rn: main_react_native,
esm5: main_esm5
},
lite: {
types: lite_types,
browser: {
require: lite_browser_require,
import: lite_browser_import
},
node: {
require: lite_node_require,
import: lite_node_import
},
rn: lite_react_native,
esm5: lite_esm5
}
};
}
exports.getPackageJsonExportPaths = getPackageJsonExportPaths;
Loading