Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch possible Safari error #7890

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Catch possible Safari error #7890

merged 2 commits into from
Jan 3, 2024

Conversation

hsubox76
Copy link
Contributor

This is part of the platform logging code and errors should not block any Firebase functionality.

Sometimes in Safari (and other Safari-based browsers), db.createObjectStore() triggers a "the database is not running a version change transaction" error which is not supposed to happen inside the onupgradeneeded event handler (abstracted to upgrade in the idb wrapper). Would guess this is an error in Safari or idb. We will just catch and warn for now to avoid spamming monitoring logs or crashing the app.

Fixes #7829

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: ad75125

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/app Patch
@firebase/app-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2023

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (f854abe)Merge (bdfb7c7)Diff
    browser14.7 kB14.7 kB+30 B (+0.2%)
    esm519.2 kB19.2 kB+30 B (+0.2%)
    main20.1 kB20.1 kB+30 B (+0.1%)
    module14.7 kB14.7 kB+30 B (+0.2%)
  • bundle

    44 size changes

    TypeBase (f854abe)Merge (bdfb7c7)Diff
    analytics (logEvent)44.0 kB44.0 kB+30 B (+0.1%)
    app-check (CustomProvider)36.9 kB36.9 kB+30 B (+0.1%)
    app-check (ReCaptchaEnterpriseProvider)39.4 kB39.4 kB+30 B (+0.1%)
    app-check (ReCaptchaV3Provider)39.4 kB39.4 kB+30 B (+0.1%)
    auth (Anonymous)73.7 kB73.7 kB+30 B (+0.0%)
    auth (EmailAndPassword)81.6 kB81.6 kB+30 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)100 kB100 kB+30 B (+0.0%)
    auth (GooglePopup)97.6 kB97.6 kB+30 B (+0.0%)
    auth (GoogleRedirect)97.8 kB97.8 kB+30 B (+0.0%)
    auth (Phone)84.0 kB84.0 kB+30 B (+0.0%)
    database (Append to a list of data)148 kB149 kB+30 B (+0.0%)
    database (Filtering data)147 kB147 kB+30 B (+0.0%)
    database (Listen for child events)164 kB164 kB+30 B (+0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB+30 B (+0.0%)
    database (Listen for value events)164 kB164 kB+30 B (+0.0%)
    database (Read data once)163 kB163 kB+30 B (+0.0%)
    database (Save data as transactions)166 kB166 kB+30 B (+0.0%)
    database (Sort data)149 kB149 kB+30 B (+0.0%)
    database (Write data)148 kB148 kB+30 B (+0.0%)
    firestore (Persistence)302 kB302 kB+30 B (+0.0%)
    firestore (Query Cursors)238 kB238 kB+30 B (+0.0%)
    firestore (Query)236 kB236 kB+30 B (+0.0%)
    firestore (Read data once)224 kB224 kB+30 B (+0.0%)
    firestore (Read Write w Persistence)321 kB321 kB+30 B (+0.0%)
    firestore (Realtime updates)226 kB226 kB+30 B (+0.0%)
    firestore (Transaction)204 kB204 kB+30 B (+0.0%)
    firestore (Write data)204 kB204 kB+30 B (+0.0%)
    firestore-lite (Query Cursors)89.1 kB89.2 kB+30 B (+0.0%)
    firestore-lite (Query)85.3 kB85.3 kB+30 B (+0.0%)
    firestore-lite (Read data once)61.6 kB61.6 kB+30 B (+0.0%)
    firestore-lite (Transaction)86.5 kB86.6 kB+30 B (+0.0%)
    firestore-lite (Write data)71.1 kB71.2 kB+30 B (+0.0%)
    functions (call)31.4 kB31.4 kB+30 B (+0.1%)
    messaging (send + receive)46.8 kB46.8 kB+30 B (+0.1%)
    performance (trace)51.2 kB51.3 kB+30 B (+0.1%)
    remote-config (getAndFetch)45.8 kB45.8 kB+30 B (+0.1%)
    storage (getBytes)41.5 kB41.6 kB+30 B (+0.1%)
    storage (getDownloadURL)43.6 kB43.6 kB+30 B (+0.1%)
    storage (getMetadata)43.1 kB43.1 kB+30 B (+0.1%)
    storage (list + listAll)42.5 kB42.5 kB+30 B (+0.1%)
    storage (updateMetadata)43.3 kB43.4 kB+30 B (+0.1%)
    storage (uploadBytes)48.2 kB48.2 kB+30 B (+0.1%)
    storage (uploadBytesResumable)58.1 kB58.2 kB+30 B (+0.1%)
    storage (uploadString)48.4 kB48.4 kB+30 B (+0.1%)

  • firebase

    TypeBase (f854abe)Merge (bdfb7c7)Diff
    firebase-app-compat.js29.2 kB29.2 kB+32 B (+0.1%)
    firebase-app.js94.0 kB94.4 kB+411 B (+0.4%)
    firebase-compat.js779 kB779 kB+32 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js90.4 kB90.4 kB+30 B (+0.0%)
    firebase-performance-standalone-compat.js67.5 kB67.5 kB+32 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PH3cT7ux0u.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 19, 2023

Size Analysis Report 1

This report is too large (140,760 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eO3YdyHLRz.html

@hsubox76 hsubox76 requested a review from DellaBitta December 20, 2023 17:41
@hsubox76 hsubox76 marked this pull request as ready for review December 20, 2023 17:41
@hsubox76 hsubox76 requested review from a team as code owners December 20, 2023 17:41
@hsubox76 hsubox76 merged commit 16728cf into master Jan 3, 2024
40 of 42 checks passed
@hsubox76 hsubox76 deleted the ch-catch-idb branch January 3, 2024 19:32
@google-oss-bot google-oss-bot mentioned this pull request Jan 16, 2024
@firebase firebase locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants