Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable nightly run with PR #7876

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Disable nightly run with PR #7876

merged 4 commits into from
Jan 4, 2024

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Dec 14, 2023 •
edited
Loading

Skip the tests against Firestore nightly as a PR presubmit check, it is activated when the workflow is manually triggered still.

@wu-hui wu-hui requested a review from a team as a code owner December 14, 2023 21:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4af5b0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wu-hui wu-hui force-pushed the wuandy/NoNightlyPR branch 2 times, most recently from d0c3ae6 to f066cc9 Compare December 14, 2023 21:17
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 14, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (2e32eeb)Merge (8b2f351)Diff
    browser14.7 kB14.7 kB+30 B (+0.2%)
    esm519.2 kB19.2 kB+30 B (+0.2%)
    main20.1 kB20.1 kB+30 B (+0.1%)
    module14.7 kB14.7 kB+30 B (+0.2%)

  • @firebase/firestore

    TypeBase (2e32eeb)Merge (8b2f351)Diff
    browser375 kB375 kB+330 B (+0.1%)
    esm5360 kB360 kB+183 B (+0.1%)
    main576 kB577 kB+550 B (+0.1%)
    module375 kB375 kB+330 B (+0.1%)
    react-native375 kB375 kB+330 B (+0.1%)

  • @firebase/firestore-lite

    TypeBase (2e32eeb)Merge (8b2f351)Diff
    browser109 kB109 kB+195 B (+0.2%)
    esm5106 kB106 kB+243 B (+0.2%)
    main150 kB150 kB+402 B (+0.3%)
    module109 kB109 kB+195 B (+0.2%)
    react-native109 kB109 kB+195 B (+0.2%)

  • bundle

    44 size changes

    TypeBase (2e32eeb)Merge (8b2f351)Diff
    analytics (logEvent)44.0 kB44.0 kB+30 B (+0.1%)
    app-check (CustomProvider)36.9 kB36.9 kB+30 B (+0.1%)
    app-check (ReCaptchaEnterpriseProvider)39.4 kB39.4 kB+30 B (+0.1%)
    app-check (ReCaptchaV3Provider)39.4 kB39.4 kB+30 B (+0.1%)
    auth (Anonymous)73.7 kB73.7 kB+30 B (+0.0%)
    auth (EmailAndPassword)81.6 kB81.6 kB+30 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup)100 kB100 kB+30 B (+0.0%)
    auth (GooglePopup)97.6 kB97.6 kB+30 B (+0.0%)
    auth (GoogleRedirect)97.8 kB97.8 kB+30 B (+0.0%)
    auth (Phone)84.0 kB84.0 kB+30 B (+0.0%)
    database (Append to a list of data)148 kB149 kB+30 B (+0.0%)
    database (Filtering data)147 kB147 kB+30 B (+0.0%)
    database (Listen for child events)164 kB164 kB+30 B (+0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB+30 B (+0.0%)
    database (Listen for value events)164 kB164 kB+30 B (+0.0%)
    database (Read data once)163 kB163 kB+30 B (+0.0%)
    database (Save data as transactions)166 kB166 kB+30 B (+0.0%)
    database (Sort data)149 kB149 kB+30 B (+0.0%)
    database (Write data)148 kB148 kB+30 B (+0.0%)
    firestore (Persistence)302 kB303 kB+234 B (+0.1%)
    firestore (Query Cursors)238 kB238 kB+203 B (+0.1%)
    firestore (Query)236 kB236 kB+203 B (+0.1%)
    firestore (Read data once)224 kB224 kB+203 B (+0.1%)
    firestore (Read Write w Persistence)?321 kB? (?)
    firestore (Realtime updates)226 kB226 kB+203 B (+0.1%)
    firestore (Transaction)204 kB204 kB+204 B (+0.1%)
    firestore (Write data)204 kB204 kB+238 B (+0.1%)
    firestore-lite (Query Cursors)89.1 kB89.4 kB+239 B (+0.3%)
    firestore-lite (Query)85.3 kB85.5 kB+239 B (+0.3%)
    firestore-lite (Read data once)61.6 kB61.7 kB+86 B (+0.1%)
    firestore-lite (Transaction)86.4 kB86.6 kB+168 B (+0.2%)
    firestore-lite (Write data)71.1 kB71.2 kB+89 B (+0.1%)
    functions (call)31.4 kB31.4 kB+30 B (+0.1%)
    messaging (send + receive)46.8 kB46.8 kB+30 B (+0.1%)
    performance (trace)51.2 kB51.3 kB+30 B (+0.1%)
    remote-config (getAndFetch)45.8 kB45.8 kB+30 B (+0.1%)
    storage (getBytes)41.5 kB41.6 kB+30 B (+0.1%)
    storage (getDownloadURL)43.6 kB43.6 kB+30 B (+0.1%)
    storage (getMetadata)43.1 kB43.1 kB+30 B (+0.1%)
    storage (list + listAll)42.5 kB42.5 kB+30 B (+0.1%)
    storage (updateMetadata)43.3 kB43.4 kB+30 B (+0.1%)
    storage (uploadBytes)48.2 kB48.2 kB+30 B (+0.1%)
    storage (uploadBytesResumable)58.1 kB58.2 kB+30 B (+0.1%)
    storage (uploadString)48.4 kB48.4 kB+30 B (+0.1%)

  • firebase

    TypeBase (2e32eeb)Merge (8b2f351)Diff
    firebase-app-compat.js29.2 kB29.2 kB+32 B (+0.1%)
    firebase-app.js94.0 kB94.4 kB+411 B (+0.4%)
    firebase-compat.js779 kB779 kB+300 B (+0.0%)
    firebase-firestore-compat.js340 kB341 kB+268 B (+0.1%)
    firebase-firestore-lite.js117 kB117 kB+195 B (+0.2%)
    firebase-firestore.js434 kB434 kB+330 B (+0.1%)
    firebase-performance-standalone-compat.es2017.js90.4 kB90.4 kB+30 B (+0.0%)
    firebase-performance-standalone-compat.js67.5 kB67.5 kB+32 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fz9CeHv75t.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 14, 2023 •
edited
Loading

Size Analysis Report 1

This report is too large (479,016 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/C4x5MqiE0h.html

@wu-hui wu-hui force-pushed the wuandy/NoNightlyPR branch from f066cc9 to 837e2f7 Compare December 15, 2023 00:06
@wu-hui wu-hui requested a review from a team as a code owner December 15, 2023 15:15
@wu-hui wu-hui requested a review from dconeybe December 15, 2023 15:29
dconeybe
dconeybe approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just add a brief description to the PR to articulate what the new way is to run the workflow against nightly? For example, is it only triggered manually? Is it run nightly? Is it run on all PRs? Thanks!

DellaBitta
DellaBitta reviewed Dec 15, 2023
View reviewed changes
.github/workflows/test-changed-firestore.yml Outdated
@@ -138,7 +140,7 @@ jobs:
test-name: ["test:browser:nightly"]
runs-on: ubuntu-latest
needs: build
if: ${{ needs.build.outputs.changed == 'true'}}
if: ${{ github.event.workflow_run.trigger_source == 'workflow_dispatch' }}
Copy link
Contributor

@DellaBitta DellaBitta Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to check if it's not pull_request in case we add new elements to on: above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wu-hui wu-hui merged commit e5fc290 into master Jan 4, 2024
40 of 42 checks passed
@wu-hui wu-hui deleted the wuandy/NoNightlyPR branch January 4, 2024 15:19
@firebase firebase locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@dconeybe dconeybe dconeybe approved these changes

Assignees

@dconeybe dconeybe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wu-hui @google-oss-bot @DellaBitta @dconeybe