Sum and average #6952
Merged
Sum and average #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regate at a time without aliasing.
…for performing general aggregations.
🦋 Changeset detectedLatest commit: 83740c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (717,088 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
wu-hui
reviewed
Jan 17, 2023
MarkDuckworth
commented
Jan 24, 2023
…js-sdk into markduckworth/sum-avg
ehsannas
approved these changes
Jan 26, 2023
ehsannas
approved these changes
Jan 26, 2023
hsubox76
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Usually prefer to add a changeset for any significant code changes because it makes it easier to trace back any bugs to a specific version (if the changes should not be announced, you can make a note and we can exclude them from the release notes). But I guess we can always just use the commit history.
* Tests for sum and average.
…kduckworth/sum-avg
NhienLam
pushed a commit
that referenced
this pull request
Feb 14, 2023
Refactoring aggregations in Firestore to support sum and average. Sum and average are not public. --------- Co-authored-by: MarkDuckworth <MarkDuckworth@users.noreply.github.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring aggregations in Firestore to support sum and average. Sum and average are not public.