Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Import Integer from google-closure-library #6813

Closed
wants to merge 10 commits into from

Conversation

dconeybe
Copy link
Contributor

No description provided.

@dconeybe dconeybe self-assigned this Nov 19, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2022

⚠️ No Changeset found

Latest commit: 5e131e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 19, 2022

Size Report 1

Affected Products

  • @firebase/webchannel-wrapper

    TypeBase (ab3f16c)Merge (eb49d4d)Diff
    esm544.7 kB49.1 kB+4.43 kB (+9.9%)
    main54.6 kB59.0 kB+4.44 kB (+8.1%)
    module42.4 kB46.8 kB+4.43 kB (+10.4%)
  • bundle

    TypeBase (ab3f16c)Merge (eb49d4d)Diff
    firestore (Persistence)276 kB281 kB+4.47 kB (+1.6%)
    firestore (Query Cursors)213 kB217 kB+4.47 kB (+2.1%)
    firestore (Query)214 kB218 kB+4.47 kB (+2.1%)
    firestore (Read data once)202 kB207 kB+4.47 kB (+2.2%)
    firestore (Realtime updates)205 kB209 kB+4.47 kB (+2.2%)
    firestore (Transaction)186 kB190 kB+4.47 kB (+2.4%)
    firestore (Write data)186 kB190 kB+4.47 kB (+2.4%)
  • firebase

    TypeBase (ab3f16c)Merge (eb49d4d)Diff
    firebase-compat.js740 kB744 kB+4.35 kB (+0.6%)
    firebase-firestore-compat.js314 kB318 kB+4.34 kB (+1.4%)
    firebase-firestore.js314 kB319 kB+4.42 kB (+1.4%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vOflqzKWdl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 19, 2022

Size Analysis Report 1

This report is too large (139,431 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NAkdtwWyKr.html

@dconeybe
Copy link
Contributor Author

The work on this PR is done. It will be incorporated into #6795 rather than being merged into master.

@dconeybe
Copy link
Contributor Author

dconeybe commented Jan 9, 2023

This change was incorporated into #6795

@dconeybe dconeybe closed this Jan 9, 2023
@dconeybe dconeybe deleted the dconeybe/IntegerFromClosure branch January 9, 2023 18:09
@firebase firebase locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants