Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bundle-size][firestore] Refine bundle definition #5773

Merged
merged 4 commits into from
Dec 4, 2021
Merged

[bundle-size][firestore] Refine bundle definition #5773

merged 4 commits into from
Dec 4, 2021

Conversation

yifanyang
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 71b8e5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (6ae54d0) and head commit (33e1319) are too large (158,808 characters) to display.

Please check below links to see details from the original test log.

@yifanyang yifanyang force-pushed the yifany/bundle-firestore branch from acfd4cf to 0cc2c56 Compare December 1, 2021 17:18
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 1, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/app

    Type Base (6ae54d0) Head (33e1319) Diff
    browser 7.74 kB 7.74 kB +1 B (+0.0%)
    esm5 9.37 kB 9.37 kB +1 B (+0.0%)
    main 10.2 kB 10.2 kB +1 B (+0.0%)
    module 7.74 kB 7.74 kB +1 B (+0.0%)

  • @firebase/firestore

    Type Base (6ae54d0) Head (33e1319) Diff
    main 426 kB 426 kB +18 B (+0.0%)

  • bundle

    Click to show 42 binary size changes.
    Type Base (6ae54d0) Head (33e1319) Diff
    analytics (logEvent) 34.7 kB 34.7 kB +1 B (+0.0%)
    app-check (CustomProvider) 27.4 kB 27.4 kB +1 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider) 29.6 kB 29.6 kB +1 B (+0.0%)
    app-check (ReCaptchaV3Provider) 29.6 kB 29.6 kB +1 B (+0.0%)
    auth (Anonymous) 56.9 kB 56.9 kB +1 B (+0.0%)
    auth (EmailAndPassword) 61.0 kB 61.0 kB +1 B (+0.0%)
    auth (GoogleFBTwitterGitHubPopup) 80.8 kB 80.7 kB -34 B (-0.0%)
    auth (GooglePopup) 80.5 kB 80.5 kB +1 B (+0.0%)
    auth (GoogleRedirect) 80.7 kB 80.7 kB +1 B (+0.0%)
    auth (Phone) 66.9 kB 66.9 kB +1 B (+0.0%)
    database (Append to a list of data) 137 kB 137 kB +1 B (+0.0%)
    database (Filtering data) 136 kB 136 kB +1 B (+0.0%)
    database (Listen for child events) 152 kB 152 kB +1 B (+0.0%)
    database (Listen for value events + Detach listeners) ? 152 kB ? (?)
    database (Listen for value events) 152 kB 152 kB +1 B (+0.0%)
    database (Read data once) 144 kB 144 kB +1 B (+0.0%)
    database (Save data as transactions) 154 kB 154 kB +1 B (+0.0%)
    database (Sort data) 138 kB 138 kB +1 B (+0.0%)
    database (Write data) 136 kB 136 kB +1 B (+0.0%)
    firestore (Persistence) ? 229 kB ? (?)
    firestore (Query Cursors) ? 189 kB ? (?)
    firestore (Query) 190 kB 190 kB +1 B (+0.0%)
    firestore (Read data once) 195 kB 178 kB -16.9 kB (-8.7%)
    firestore (Realtime updates) 180 kB 180 kB +1 B (+0.0%)
    firestore (Transaction) ? 163 kB ? (?)
    firestore (Write data) ? 162 kB ? (?)
    firestore-lite (Query Cursors) ? 56.3 kB ? (?)
    firestore-lite (Query) 59.4 kB 59.4 kB +1 B (+0.0%)
    firestore-lite (Read data once) 57.2 kB 43.9 kB -13.3 kB (-23.3%)
    firestore-lite (Transaction) ? 61.2 kB ? (?)
    firestore-lite (Write data) ? 46.8 kB ? (?)
    functions (call) 18.3 kB 18.3 kB +1 B (+0.0%)
    messaging (send + receive) 37.8 kB 37.8 kB +1 B (+0.0%)
    performance (trace) 42.3 kB 42.3 kB +1 B (+0.0%)
    remote-config (getAndFetch) 36.7 kB 36.7 kB +1 B (+0.0%)
    storage (getDownloadURL) 28.7 kB 28.7 kB +1 B (+0.0%)
    storage (getMetadata) 28.1 kB 28.1 kB +1 B (+0.0%)
    storage (list + listAll) 27.5 kB 27.5 kB +1 B (+0.0%)
    storage (updateMetadata) 28.4 kB 28.4 kB +1 B (+0.0%)
    storage (uploadBytes) 32.9 kB 32.9 kB +1 B (+0.0%)
    storage (uploadBytesResumable) 42.4 kB 42.4 kB +1 B (+0.0%)
    storage (uploadString) 33.1 kB 33.1 kB +1 B (+0.0%)

  • firebase

    Type Base (6ae54d0) Head (33e1319) Diff
    firebase-app-compat.js 17.9 kB 17.9 kB +1 B (+0.0%)
    firebase-app.js 51.3 kB 51.3 kB +1 B (+0.0%)
    firebase-compat.js 753 kB 753 kB +2 B (+0.0%)
    firebase-firestore-lite.js 245 kB 245 kB -13 B (-0.0%)
    firebase-firestore.js 766 kB 766 kB -13 B (-0.0%)
    firebase-performance-standalone-compat.es2017.js 78.9 kB 78.9 kB +1 B (+0.0%)
    firebase-performance-standalone-compat.js 57.0 kB 57.0 kB +1 B (+0.0%)

Test Logs

@yifanyang yifanyang force-pushed the yifany/bundle-firestore branch 2 times, most recently from 97e851f to 31cd43e Compare December 2, 2021 02:24
schmidt-sebastian
schmidt-sebastian reviewed Dec 2, 2021
View reviewed changes
repo-scripts/size-analysis/bundle-definitions/firestore-lite.json Outdated
"getFirestore",
"collection",
"doc",
"getDoc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDocs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

repo-scripts/size-analysis/bundle-definitions/firestore.json Outdated
"getFirestore",
"collection",
"doc",
"getDoc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDocs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

repo-scripts/size-analysis/bundle-definitions/firestore.json Outdated
Comment on lines 191 to 196
"collection",
"onSnapshot",
"where",
"query",
"enableNetwork",
"disableNetwork"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove all those - they are tested elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yifanyang yifanyang force-pushed the yifany/bundle-firestore branch from 2ce28e7 to 0ce9ed4 Compare December 3, 2021 00:08
schmidt-sebastian
schmidt-sebastian reviewed Dec 3, 2021
View reviewed changes
repo-scripts/size-analysis/bundle-definitions/firestore.json Outdated
"path": "firestore",
"imports": [
"getFirestore",
"enableIndexedDbPersistence"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use enableMultiTabIndexedDbPersistence? That might provide more interesting data as it pulls in even more components.

@yifanyang yifanyang merged commit 931c80d into master Dec 4, 2021
@yifanyang yifanyang deleted the yifany/bundle-firestore branch December 4, 2021 01:32
@firebase firebase locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yifanyang @google-oss-bot @Feiyang1 @schmidt-sebastian