Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-init auth-internal after initializing auth #5071

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Jun 25, 2021

Fixes #4932

Since Firestore doesn't call authProvider.get() to work with asynchronously loaded Auth anymore (changed to use authProvider.onInit() in v9 which is shared with v8), auth-interal needs to be proactively initialized after Auth has been initialized.

Note that it only affects v8, auth-internal is already initialized proactively in v9.

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2021

🦋 Changeset detected

Latest commit: 4773d3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@firebase/auth Patch
@firebase/component Patch
firebase Patch
@firebase/storage Patch
@firebase/analytics Patch
@firebase/app-check Patch
@firebase/app Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Feiyang1 Feiyang1 requested a review from egilmorez as a code owner June 25, 2021 20:00
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2021

Binary Size Report

Affected SDKs

  • @firebase/auth

    Type Base (3ea1e1f) Head (a19f12b) Diff
    browser 181 kB 181 kB +75 B (+0.0%)
    main 181 kB 181 kB +75 B (+0.0%)
    module 181 kB 181 kB +75 B (+0.0%)
  • @firebase/component

    Type Base (3ea1e1f) Head (a19f12b) Diff
    browser 8.33 kB 8.33 kB -2 B (-0.0%)
    esm2017 6.32 kB 6.32 kB -2 B (-0.0%)
    main 8.67 kB 8.67 kB -2 B (-0.0%)
    module 8.33 kB 8.33 kB -2 B (-0.0%)
  • firebase

    Type Base (3ea1e1f) Head (a19f12b) Diff
    firebase-auth.js 177 kB 177 kB +75 B (+0.0%)
    firebase.js 893 kB 893 kB +75 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2021

Size Analysis Report

Affected Products

No changes between base commit (3ea1e1f) and head commit (a19f12b).

@schmidt-sebastian
Copy link
Contributor

FYI @sam-gc I am probably going to rely on you for the review since this is not my area of expertise.

@Feiyang1 Feiyang1 assigned hsubox76 and unassigned sam-gc and schmidt-sebastian Jun 28, 2021
@Feiyang1 Feiyang1 merged commit 56a6a9d into master Jun 28, 2021
@Feiyang1 Feiyang1 deleted the fei-auth-firestore branch June 28, 2021 23:04
@google-oss-bot google-oss-bot mentioned this pull request Jun 28, 2021
@firebase firebase locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.6.2 breaks auth/firestore rules
5 participants