fix other firefox installs, revert test file

firebase · Nov 28, 2022 · 7a03687 · 7a03687
1 parent 0c88dcf
commit 7a03687
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml
@@ -38,7 +38,10 @@ jobs:
         run: xvfb-run yarn test:changed auth
   test-firefox:
     name: Test Auth on Firefox If Changed
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: install Firefox stable

diff --git a/.github/workflows/test-changed-firestore.yml b/.github/workflows/test-changed-firestore.yml
@@ -34,6 +34,9 @@ jobs:
 
   test-firefox:
     name: Test Firestore on Firefox If Changed
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
     runs-on: ubuntu-20.04
 
     steps:

diff --git a/.github/workflows/test-changed.yml b/.github/workflows/test-changed.yml
@@ -34,7 +34,10 @@ jobs:
 
   test-firefox:
     name: Test Packages With Changed Files in Firefox
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: Checkout Repo

diff --git a/packages/firestore/src/index/directional_index_byte_encoder.ts b/packages/firestore/src/index/directional_index_byte_encoder.ts
@@ -17,8 +17,6 @@
 
 import { ByteString } from '../util/byte_string';
 
-// Trigger Firestore CI tests
-
 /** An index value encoder.  */
 export interface DirectionalIndexByteEncoder {
   // Note: This code is copied from the backend. Code that is not used by