Fix 9.0.0 Functions Error Code Regressions #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
approved these changes
May 30, 2022
ncooke3
approved these changes
May 31, 2022
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Jun 19, 2022
This was a regression between firebase-ios-sdk < v9 and >= v9.1.0 can revert with firebase-ios-sdk > 9.1.0 - firebase/firebase-ios-sdk#9862
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Jun 19, 2022
This was a regression between firebase-ios-sdk < v9 and >= v9.1.0 can revert with firebase-ios-sdk > 9.1.0 - firebase/firebase-ios-sdk#9862
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Jun 19, 2022
This was a regression between firebase-ios-sdk < v9 and >= v9.1.0 can revert with firebase-ios-sdk > 9.1.0 - firebase/firebase-ios-sdk#9862 BREAKING CHANGE: if your firebase functions return custom HttpsError instances, you must not upgrade yet, custom errors suffered a regression in firebase-ios-sdk 9.0.0 and 9.1.0. The next firebase-ios-sdk release fixes this regression, at which point you may safely use this release in combination with overriding the firebase-ios-sdk version in your Podfile
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Jun 19, 2022
This was a regression between firebase-ios-sdk < v9 and >= v9.1.0 can revert with firebase-ios-sdk > 9.1.0 - firebase/firebase-ios-sdk#9862 BREAKING CHANGE: if your firebase functions return custom HttpsError instances, you must not upgrade yet, custom errors suffered a regression in firebase-ios-sdk 9.0.0 and 9.1.0. The next firebase-ios-sdk release fixes this regression, at which point you may safely use this release in combination with overriding the firebase-ios-sdk version in your Podfile
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Jun 20, 2022
This was a regression between firebase-ios-sdk < v9 and >= v9.1.0 can revert with firebase-ios-sdk > 9.1.0 - firebase/firebase-ios-sdk#9862 BREAKING CHANGE: if your firebase functions return custom HttpsError instances, you must not upgrade yet, custom errors suffered a regression in firebase-ios-sdk 9.0.0 and 9.1.0. The next firebase-ios-sdk release fixes this regression, at which point you may safely use this release in combination with overriding the firebase-ios-sdk version in your Podfile
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Jun 20, 2022
This was a regression between firebase-ios-sdk < v9 and >= v9.1.0 can revert with firebase-ios-sdk > 9.1.0 - firebase/firebase-ios-sdk#9862 BREAKING CHANGE: if your firebase functions return custom HttpsError instances, you must not upgrade yet, custom errors suffered a regression in firebase-ios-sdk 9.0.0 and 9.1.0. The next firebase-ios-sdk release fixes this regression, at which point you may safely use this release in combination with overriding the firebase-ios-sdk version in your Podfile
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Jun 20, 2022
This was a regression between firebase-ios-sdk < v9 and >= v9.1.0 can revert with firebase-ios-sdk > 9.1.0 - firebase/firebase-ios-sdk#9862 BREAKING CHANGE: if your firebase functions return custom HttpsError instances, you must not upgrade yet, custom errors suffered a regression in firebase-ios-sdk 9.0.0 and 9.1.0. The next firebase-ios-sdk release fixes this regression, at which point you may safely use this release in combination with overriding the firebase-ios-sdk version in your Podfile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9855
The
INVLID_ARGUMENTtypo caused #9855. I also noticed a few other typos from porting FUNError.m to FunctionsError.swift.Added a variation of the react-native integration test that found this issue.