-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore: pin googletest to a commit that supports c++14 in cmake builds #14474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void breaking the build over usage of deprecated things
…TENSIONS ON), which was added 7 years ago in #715
…E_CXX_EXTENSIONS ON), which was added 7 years ago in #715" This reverts commit f0a3334. The following compiler error results from removing `set(CMAKE_CXX_EXTENSIONS ON)`: ``` FAILED: Firestore/core/test/unit/util/CMakeFiles/firestore_util_test.dir/comparison_test.cc.o /usr/bin/ccache /usr/bin/c++ -DCARES_STATICLIB -DFIREBASE_TESTS_BUILT_BY_CMAKE -DFIRESTORE_HAVE_CONFIG_DETECTED_H -DPB_ENABLE_MALLOC -DPB_FIELD_32BIT -DPB_NO_PACKED_STRUCTS=1 -Ifirebase-ios-sdk/main/build -Ifirebase-ios-sdk/main -Ifirebase-ios-sdk/main/build/external/src/abseil-cpp -Ifirebase-ios-sdk/main/Firestore/core/include -Ifirebase-ios-sdk/main/build/external/src/leveldb/include -Ifirebase-ios-sdk/main/build/external/src/snappy-build -Ifirebase-ios-sdk/main/build/external/src/snappy -Ifirebase-ios-sdk/main/build/external/src/nanopb -Ifirebase-ios-sdk/main/Firestore/Protos/nanopb -Ifirebase-ios-sdk/main/build/external/src/grpc/include -Ifirebase-ios-sdk/main/build/external/src/re2 -Ifirebase-ios-sdk/main/build/external/src/grpc-build/third_party/cares/cares -Ifirebase-ios-sdk/main/build/external/src/cares -Ifirebase-ios-sdk/main/build/external/src/protobuf/src -isystem firebase-ios-sdk/main/build/external/src/googletest/googletest/include -isystem firebase-ios-sdk/main/build/external/src/googletest/googletest -isystem firebase-ios-sdk/main/build/external/src/googletest/googlemock/include -isystem firebase-ios-sdk/main/build/external/src/googletest/googlemock -isystem $HOMEBREW_PREFIX/Cellar/openssl@3/3.4.1/include -Wno-format-zero-length -g -std=c++14 -Wall -Wextra -Werror -Wformat -Wuninitialized -fno-common -Wunused-function -Wunused-value -Wunused-variable -fdiagnostics-color -Wno-error=redundant-move -Wno-error=deprecated-declarations -Wreorder -Werror=reorder -MD -MT Firestore/core/test/unit/util/CMakeFiles/firestore_util_test.dir/comparison_test.cc.o -MF Firestore/core/test/unit/util/CMakeFiles/firestore_util_test.dir/comparison_test.cc.o.d -o Firestore/core/test/unit/util/CMakeFiles/firestore_util_test.dir/comparison_test.cc.o -c firebase-ios-sdk/main/Firestore/core/test/unit/util/comparison_test.cc firebase-ios-sdk/main/Firestore/core/test/unit/util/comparison_test.cc:196:27: error: exponent has no digits 196 | double min_sub_normal = 0x1.0p-1074; | ^~~~~~ ```
…ons to avoid breaking the build over usage of deprecated things" This reverts commit da81417. Although this change seems reasonable, it's out of scope for this PR and can be applied later, if desired.
paulb777
approved these changes
Feb 20, 2025
Thanks @dconeybe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, Firestore's cmake build always built against the
main
branch of https://github.com/google/googletest:firebase-ios-sdk/cmake/external/googletest.cmake
Line 23 in bbd9fb3
This worked fine, until googletest dropped c++14 support on Feb 10, 2025 in commit google/googletest@c00fd25. Since firebase-ios-sdk requires c++14 support, this caused all sorts of build errors (see examples below). The fix in this PR is to pin googletest at the last commit that supported c++14.
and
#no-changelog