Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Suppress deprecation build warning #14420

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[Auth] Suppress deprecation build warning #14420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseAuth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Unreleased
- [changed] Using reCAPTCHA Enterprise and Firebase Auth requires reCAPTCHA
Enterprise 18.7.0 or later.
- [fixed] Suppress deprecation build warning introduced in 11.8.0.

# 11.8.0
- [added] Added `ActionCodeSettings.linkDomain` to customize the Firebase Hosting link domain
Expand Down
13 changes: 12 additions & 1 deletion FirebaseAuth/Sources/Swift/Backend/RPC/GetOOBConfirmationCodeRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ private let kClientType = "clientType"
/// The key for the "recaptchaVersion" value in the request.
private let kRecaptchaVersion = "recaptchaVersion"

protocol SuppressWarning {
var dynamicLinkDomain: String? { get set }
}

extension ActionCodeSettings: SuppressWarning {}

@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
class GetOOBConfirmationCodeRequest: IdentityToolkitRequest, AuthRPCRequest {
typealias Response = GetOOBConfirmationCodeResponse
Expand Down Expand Up @@ -177,7 +183,12 @@ class GetOOBConfirmationCodeRequest: IdentityToolkitRequest, AuthRPCRequest {
androidMinimumVersion = actionCodeSettings?.androidMinimumVersion
androidInstallApp = actionCodeSettings?.androidInstallIfNotAvailable ?? false
handleCodeInApp = actionCodeSettings?.handleCodeInApp ?? false
dynamicLinkDomain = actionCodeSettings?.dynamicLinkDomain
dynamicLinkDomain =
if let actionCodeSettings {
(actionCodeSettings as SuppressWarning).dynamicLinkDomain
} else {
nil
}
linkDomain = actionCodeSettings?.linkDomain

super.init(
Expand Down
Loading