Make suspend threads for on-demand fatal thread recording configurable #14391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9849f86 to
231c7a4
Compare
|
Verified backend change is here, merge the code. https://screenshot.googleplex.com/5DfnhAbfQYQDCNY |
themiswang
added a commit
that referenced
this pull request
Feb 18, 2025
)" This reverts commit 4ed50a9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For on-demand fatal we don't want to do suspend then record the threads info.
eg. If there is an audio thread, user might experiencing audio glitch during crash recording
Also added gating flag to settings, backend change: cl/725699502