Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared_ptr instead of unique_ptr #14353

Merged
merged 2 commits into from
Jan 16, 2025
Merged

shared_ptr instead of unique_ptr #14353

merged 2 commits into from
Jan 16, 2025

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Jan 15, 2025 •
edited
Loading

Use shared_ptr instead of unique_ptr as Swift cannot use unique_ptr directly.

Also adding some minor changes picked up by tools.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link
Contributor

Apple API Diff Report

Commit: f5cd1bc
Last updated: Wed Jan 15 12:21 PST 2025
View workflow logs & download artifacts

[BUILD ERROR] FirebaseFirestoreInternal

@wu-hui wu-hui requested a review from cherylEnkidu January 16, 2025 15:33
@wu-hui wu-hui changed the title Wuandy/swift cpp fixes shared_ptr instead of unique_ptr Jan 16, 2025
@cherylEnkidu cherylEnkidu merged commit 3fc8a15 into cheryllin/firestoreSwiftCpp Jan 16, 2025
18 of 20 checks passed
@cherylEnkidu cherylEnkidu deleted the wuandy/SwiftCppFixes branch January 16, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels
api: firestore public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @cherylEnkidu