Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Port UserDefaultsManagerTests.swift #14330

Merged
merged 2 commits into from
Jan 10, 2025
Merged

[Config] Port UserDefaultsManagerTests.swift #14330

merged 2 commits into from
Jan 10, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 9, 2025

Generated tests are taking more time to refine

#no-changelog

ncooke3
ncooke3 commented Jan 9, 2025
View reviewed changes
FirebaseRemoteConfig/Tests/SwiftUnit/UserDefaultsManagerOrigTests.swift
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff with https://github.com/firebase/firebase-ios-sdk/blob/rc-swift/FirebaseRemoteConfig/Tests/Unit/RCNUserDefaultsManagerTests.m

@ncooke3 ncooke3 merged commit 1954363 into rc-swift Jan 10, 2025
15 of 18 checks passed
@ncooke3 ncooke3 deleted the nc/rc-swift-tests-2 branch January 10, 2025 17:41
paulb777 pushed a commit that referenced this pull request Jan 17, 2025
@ncooke3 @paulb777
[Config] Port UserDefaultsManagerTests.swift (#14330)
3356ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncooke3 @paulb777