Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Update decoders for consistency with v10 nil behavior #14212

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Dec 5, 2024

Decoding Initializer Comparison between Firebase 11 and Firebase 10: Firebase 10 allowed many properties to be decoded as nil. This PR restores much of that behavior.

Addresses comments in audit below except:

  • Avoided changing public APIs: AuthDataResult, MultiFactorInfo, and AdditionalUserInfo
  • 4 and 5: F11 will only decode more than F10 - like zero length strings
  • 7 A non-nil accessToken is fundamental for SecureTokenService
  • 8 A non-nil phoneNumber is fundamental for PhoneAuthCredential

Screenshot 2024-12-04 at 6 01 11 PM

@paulb777 paulb777 requested a review from ncooke3 December 5, 2024 02:50
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit 424c02b into main Dec 5, 2024
55 checks passed
@paulb777 paulb777 deleted the pb-consistent-decoding branch December 5, 2024 04:04
@firebase firebase locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants