-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auth] Add support for upcoming Recaptcha changes #14201
Merged
Merged
+81
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
commented
Dec 5, 2024
FirebaseAuth/Sources/Swift/Utilities/AuthRecaptchaVerifier.swift
Outdated
Show resolved
Hide resolved
ncooke3
commented
Dec 6, 2024
Adding this to M158 milestone for consideration. Will probably slip to M159. |
ncooke3
commented
Dec 9, 2024
ncooke3
commented
Dec 9, 2024
FirebaseAuth/Sources/Swift/Utilities/AuthRecaptchaVerifier.swift
Outdated
Show resolved
Hide resolved
paulb777
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting rid of the ObjC!
FirebaseAuth/Sources/Swift/Utilities/AuthRecaptchaVerifier.swift
Outdated
Show resolved
Hide resolved
Moved back to a later milestone as new Recaptcha version is not yet released. |
Moved back to a later milestone as new Recaptcha version is not yet released. |
ncooke3
commented
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding PR for google/interop-ios-for-google-sdks#16
that is backwards compatible for Recaptcha ≤18.6(edit: backwards compatible is not needed due to dependency versioning)Support Cases
Testing (manual tests– is reCaptcha token generated?)
try await Auth.auth().initializeRecaptchaConfig()
throws error when Recaptcha is not linkedTODOs
cc: @walterjgsp