Fixing upload-symbols run script argument order #13966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed argument order since the <paths> argument should be in the end of the arguments list
themiswang
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thank you for the fixing! Do you mind also add a release note to the CHANGELOG under Crashlytics?
|
Gonna merge the change and add Changelog later since tomorrow is code freeze for next release |
Merged
|
Oh I'm sorry I missed your comment. Do you still need me to add a changelog? edit: oh you added yourself. thanks for merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed argument order since the paths argument should be in the end of the arguments list. This fixes #13965