Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async FunctionsContextProvider.context(options:) #13900

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

yakovmanshin
Copy link
Contributor

  • Introduced FunctionsContextProvider.context(options:), an async / await version of getContext(options:_:)
  • Added tests

@yakovmanshin
Copy link
Contributor Author

There’s a separate pull request which takes advantage of this method (the PR will require a rebase so it’s a draft for now).

@ncooke3 ncooke3 self-assigned this Oct 16, 2024
* Introduced `FunctionsContextProvider.context(options:)`, an async / await version of `getContext(options:_:)`
* Added tests
@yakovmanshin yakovmanshin force-pushed the async-functions-context branch from 9a19e07 to 0c74117 Compare October 24, 2024 10:41
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yakovmanshin!

@ncooke3 ncooke3 merged commit 865535f into firebase:main Oct 29, 2024
38 checks passed
@yakovmanshin yakovmanshin deleted the async-functions-context branch October 29, 2024 17:02
@firebase firebase locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants