Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update versions for Release 10.25.0 #12743

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[Release] Update versions for Release 10.25.0 #12743

merged 1 commit into from
Apr 10, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 10, 2024

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from 56.83% (d07db9b) to 56.82% (cf6d04a) by -0.01%.

    FilenameBase (d07db9b)Merge (cf6d04a)Diff
    FSRWebSocket.m38.29%38.14%-0.15%
  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    Overall coverage changed from 61.52% (d07db9b) to 77.22% (cf6d04a) by +15.70%.

    FilenameBase (d07db9b)Merge (cf6d04a)Diff
    FDLDeviceHeuristicsHelper.m0.00%100.00%+100.00%
    FDLUtilities.m75.40%97.22%+21.83%
    FIRDLDefaultRetrievalProcessV2.m14.04%74.27%+60.23%
    FIRDLJavaScriptExecutor.m24.81%82.95%+58.14%
    FIRDynamicLink.m74.07%75.93%+1.85%
    FIRDynamicLinkNetworking.m45.09%80.67%+35.58%
  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.17% (d07db9b) to 88.19% (cf6d04a) by +0.02%.

    FilenameBase (d07db9b)Merge (cf6d04a)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.53%-0.29%
    leveldb_persistence.cc93.59%92.31%-1.28%
    lru_garbage_collector.cc96.06%91.34%-4.72%
    status.cc75.89%73.05%-2.84%
    write_stream.cc94.37%91.55%-2.82%
  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.11% (d07db9b) to 60.09% (cf6d04a) by -0.02%.

    FilenameBase (d07db9b)Merge (cf6d04a)Diff
    FIRMessagingCheckinPreferences.m98.02%93.07%-4.95%
    FIRMessagingPendingTopicsList.m89.02%90.59%+1.57%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MojZtrxDoY.html

@ncooke3 ncooke3 requested a review from paulb777 April 10, 2024 17:53
@ncooke3
Copy link
Member Author

ncooke3 commented Apr 10, 2024

There is one integration test in macOS 14 that keeps failing. https://github.com/firebase/firebase-ios-sdk/actions/runs/8633455305/job/23672137911?pr=12743 I'll look into reproducing it locally.

@paulb777
Copy link
Member

Thanks. It's been passing in recent nightlies. I don't think the core-internal test needs to block this PR.

@ncooke3 ncooke3 merged commit e93e745 into main Apr 10, 2024
614 of 618 checks passed
@ncooke3 ncooke3 deleted the version-10.25 branch April 10, 2024 21:40
@firebase firebase locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants