Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nanopb version with privacy manifest #12412

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Enable nanopb version with privacy manifest #12412

merged 1 commit into from
Feb 23, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 21, 2024 •
edited
Loading

nanopb 0.3.9.10 or 2.30910.0 introduces a privacy manifest for nanopb

Confirmed the Privacy manifest is being built into the zip after updating SpecsStaging

CI failures match main and are related to a zip builder issue with GoogleUtilities

Screenshot 2024-02-22 at 3 51 03 PM

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseInAppMessaging-iOS-FirebaseInAppMessaging.framework

    Overall coverage changed from ? (1ed6d66) to 44.74% (b5b9e85) by ?.

    45 individual files with coverage change

    FilenameBase (1ed6d66)Merge (b5b9e85)Diff
    CustomInAppMessageDisplayViewModifier.swift?0.00%?
    FIRIAMActionURLFollower.m?52.78%?
    FIRIAMActivityLogger.m?60.96%?
    FIRIAMAnalyticsEventLoggerImpl.m?60.71%?
    FIRIAMBannerViewController.m?0.00%?
    FIRIAMBannerViewUIWindow.m?0.00%?
    FIRIAMBaseRenderingViewController.m?0.00%?
    FIRIAMBookKeeper.m?88.41%?
    FIRIAMCardViewController.m?0.00%?
    FIRIAMClearcutHttpRequestSender.m?0.00%?
    FIRIAMClearcutLogger.m?62.50%?
    FIRIAMClearcutLogStorage.m?62.50%?
    FIRIAMClearcutUploader.m?90.34%?
    FIRIAMClientInfoFetcher.m?61.98%?
    FIRIAMDefaultDisplayImpl.m?1.78%?
    FIRIAMDisplayCheckOnAnalyticEventsFlow.m?0.00%?
    FIRIAMDisplayCheckOnAppForegroundFlow.m?0.00%?
    FIRIAMDisplayCheckOnFetchDoneNotificationFlow.m?0.00%?
    FIRIAMDisplayCheckTriggerFlow.m?0.00%?
    FIRIAMDisplayExecutor.m?66.96%?
    FIRIAMDisplayTriggerDefinition.m?68.42%?
    FIRIAMElapsedTimeTracker.m?92.31%?
    FIRIAMFetchFlow.m?80.35%?
    FIRIAMFetchOnAppForegroundFlow.m?0.00%?
    FIRIAMFetchResponseParser.m?86.11%?
    FIRIAMImageOnlyViewController.m?0.00%?
    FIRIAMMessageClientCache.m?78.36%?
    FIRIAMMessageContentDataWithImageURL.m?80.88%?
    FIRIAMMessageDefinition.m?100.00%?
    FIRIAMModalViewController.m?0.00%?
    FIRIAMMsgFetcherUsingRestful.m?71.01%?
    FIRIAMRenderingEffectSetting.m?100.00%?
    FIRIAMRenderingWindowHelper.m?0.00%?
    FIRIAMRuntimeManager.m?0.00%?
    FIRIAMSDKModeManager.m?93.22%?
    FIRIAMSDKSettings.m?0.00%?
    FIRIAMServerMsgFetchStorage.m?0.00%?
    FIRIAMTimeFetcher.m?0.00%?
    FIRInAppMessaging+Bootstrap.m?0.00%?
    FIRInAppMessaging.m?3.37%?
    FIRInAppMessagingRenderingDataClasses.m?89.29%?
    NSString+FIRInterlaceStrings.m?100.00%?
    SwiftUIPreviewHelpers.swift?0.00%?
    UIApplication+FIRForegroundWindowScene.m?0.00%?
    UIColor+FIRIAMHexString.m?100.00%?

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from ? (1ed6d66) to 60.11% (b5b9e85) by ?.

    29 individual files with coverage change

    FilenameBase (1ed6d66)Merge (b5b9e85)Diff
    FIRMessaging.m?55.20%?
    FIRMessagingAnalytics.m?82.14%?
    FIRMessagingAPNSInfo.m?87.76%?
    FIRMessagingAuthKeychain.m?87.42%?
    FIRMessagingAuthService.m?92.03%?
    FIRMessagingBackupExcludedPlist.m?82.09%?
    FIRMessagingCheckinPreferences.m?98.02%?
    FIRMessagingCheckinService.m?86.49%?
    FIRMessagingCheckinStore.m?81.68%?
    FIRMessagingContextManagerService.m?85.71%?
    FIRMessagingExtensionHelper.m?77.92%?
    FIRMessagingKeychain.m?93.39%?
    FIRMessagingLogger.m?100.00%?
    FIRMessagingPendingTopicsList.m?89.02%?
    FIRMessagingPersistentSyncMessage.m?38.10%?
    FIRMessagingPubSub.m?52.14%?
    FIRMessagingRemoteNotificationsProxy.m?76.35%?
    FIRMessagingRmqManager.m?57.42%?
    FIRMessagingSyncMessageManager.m?70.73%?
    FIRMessagingTokenDeleteOperation.m?0.00%?
    FIRMessagingTokenFetchOperation.m?75.91%?
    FIRMessagingTokenInfo.m?66.92%?
    FIRMessagingTokenManager.m?14.82%?
    FIRMessagingTokenOperation.m?95.04%?
    FIRMessagingTokenStore.m?53.17%?
    FIRMessagingTopicOperation.m?0.00%?
    FIRMessagingUtilities.m?54.90%?
    NSDictionary+FIRMessaging.m?27.27%?
    NSError+FIRMessaging.m?100.00%?

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from ? (1ed6d66) to 94.71% (b5b9e85) by ?.

    43 individual files with coverage change

    FilenameBase (1ed6d66)Merge (b5b9e85)Diff
    FIRHTTPMetric.m?100.00%?
    FIRPerformance.m?95.00%?
    FIRTrace.m?93.63%?
    FPRAppActivityTracker.m?93.08%?
    FPRClassInstrumentor.m?91.67%?
    FPRClient.m?94.49%?
    FPRConfiguration.m?63.16%?
    FPRConfigurations.m?95.00%?
    FPRConsoleURLGenerator.m?100.00%?
    FPRCounterList.m?100.00%?
    FPRCPUGaugeCollector.m?89.91%?
    FPRCPUGaugeData.m?100.00%?
    FPRDataUtils.m?96.04%?
    FPRDiagnostics.m?84.48%?
    FPRGaugeManager.m?95.42%?
    FPRGDTEvent.m?80.00%?
    FPRGDTLogger.m?100.00%?
    FPRGDTLogSampler.m?90.16%?
    FPRGDTRateLimiter.m?94.59%?
    FPRInstrument.m?100.00%?
    FPRInstrumentation.m?100.00%?
    FPRMemoryGaugeCollector.m?94.12%?
    FPRMemoryGaugeData.m?100.00%?
    FPRNanoPbUtils.m?86.53%?
    FPRNetworkInstrumentHelpers.m?29.17%?
    FPRNetworkTrace.m?95.25%?
    FPRNSURLConnectionDelegate.m?61.36%?
    FPRNSURLConnectionDelegateInstrument.m?98.70%?
    FPRNSURLConnectionInstrument.m?96.62%?
    FPRNSURLSessionDelegate.m?100.00%?
    FPRNSURLSessionDelegateInstrument.m?99.24%?
    FPRNSURLSessionInstrument.m?97.58%?
    FPRObjectInstrumentor.m?83.33%?
    FPRPerfDate.m?50.00%?
    FPRProxyObjectHelper.m?100.00%?
    FPRRemoteConfigFlags.m?98.09%?
    FPRScreenTraceTracker.m?97.69%?
    FPRSelectorInstrumentor.m?90.38%?
    FPRSessionDetails.m?96.43%?
    FPRSessionManager.m?100.00%?
    FPRTraceBackgroundActivityTracker.m?100.00%?
    FPRUIViewControllerInstrument.m?95.18%?
    FPRURLFilter.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xbE3CQq3r3.html

@paulb777 paulb777 mentioned this pull request Feb 22, 2024
Merged
@paulb777 paulb777 merged commit 0b9af70 into main Feb 23, 2024
189 of 200 checks passed
@paulb777 paulb777 deleted the pb-update-nanopb branch February 23, 2024 00:37
@firebase firebase locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@morganchen12 morganchen12 Awaiting requested review from morganchen12

Assignees
No one assigned
Labels
api: analytics api: crashlytics api: inappmessaging Firebase In App Messaging api: messaging api: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @andrewheard