Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Manifests for named Firebase SDKs #12407

Merged
merged 25 commits into from
Feb 23, 2024
Merged

Privacy Manifests for named Firebase SDKs #12407

merged 25 commits into from
Feb 23, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 20, 2024

Add privacy manifests for the Firebase SDKs named in https://developer.apple.com/support/third-party-SDK-requirements/

FirebaseCoreDiagnostics is not included because it is no longer part of the product.

Other non-named Firebase SDKs are still being investigated.

@google-oss-bot
Copy link

google-oss-bot commented Feb 20, 2024

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.17% (30dd2ba) to 88.14% (9f68afd) by -0.03%.

    FilenameBase (30dd2ba)Merge (9f68afd)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.63%98.82%+0.20%
    leveldb_persistence.cc92.31%93.59%+1.28%
    lru_garbage_collector.cc91.34%96.06%+4.72%
    status.cc73.05%75.89%+2.84%
  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.06% (30dd2ba) to 60.11% (9f68afd) by +0.05%.

    FilenameBase (30dd2ba)Merge (9f68afd)Diff
    FIRMessagingCheckinPreferences.m93.07%98.02%+4.95%
    FIRMessagingPendingTopicsList.m89.80%89.02%-0.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xUzUUD98Xw.html

@paulb777 paulb777 changed the title Privacy Manifests Draft Privacy Manifests for named Firebase SDKs Feb 23, 2024
@paulb777 paulb777 requested a review from andrewheard February 23, 2024 18:53
@paulb777
Copy link
Member Author

Tests are failing because the recently published Promises 2.4.0 is coming and going from the CDN

@paulb777 paulb777 added this to the 10.22.0 - M144 milestone Feb 23, 2024
@paulb777 paulb777 merged commit 3539c2b into main Feb 23, 2024
328 checks passed
@paulb777 paulb777 deleted the nc/m144-manifests branch February 23, 2024 23:08
@firebase firebase locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants