Make instanceForProtocol:inContainer: return nullable T
#12391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Would you touch |
paulb777
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
LGTM
I've seen the storage quickstart issue occasionally. Maybe resolved by firebase/quickstart-ios#1559?
This reverts commit da2434f.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
+ (T)instanceForProtocol:inContainer:inFIRComponentTypeto return anullable Tinstead ofT. The underlying call toinstanceForProtocol:inFIRComponentContainercan returnnil.This is a follow-up that addresses #12387 (comment).
#no-changelog