Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate a few more retry steps #12371

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Migrate a few more retry steps #12371

merged 3 commits into from
Feb 7, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 7, 2024

#no-changelog

See if this reduces nightly flakiness

@google-oss-bot
Copy link

google-oss-bot commented Feb 7, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 67.92% (d95c62b) to 68.47% (e7c8b4f) by +0.55%.

    FilenameBase (d95c62b)Merge (e7c8b4f)Diff
    FIRAuth.m82.65%83.68%+1.03%
    FIRAuthKeychainServices.m52.36%59.66%+7.30%
    FIRAuthStoredUserManager.m17.24%52.87%+35.63%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yLiABkANUR.html

@paulb777 paulb777 requested a review from ncooke3 February 7, 2024 19:12
@paulb777 paulb777 enabled auto-merge (squash) February 7, 2024 19:12
@paulb777 paulb777 merged commit 0bb0dcf into main Feb 7, 2024
112 checks passed
@paulb777 paulb777 deleted the pb-retry-migratio branch February 7, 2024 19:15
@paulb777 paulb777 mentioned this pull request Feb 8, 2024
Open
@firebase firebase locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ncooke3