Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try GHA retry #12341

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Try GHA retry #12341

merged 6 commits into from
Feb 1, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 1, 2024

This validates a proof of concept of using GHA retry (#11253) instead of travis retry.

It doesn't address the Storage Integration flake, but it successfully retries it.

#no-changelog

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I see the 3 attempts in the logs.

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The retry_wait_seconds seems like an interesting option that we may able to leverage for cases where an instant retry may lead to the same failure as before (e.g. too many requests errors).

@paulb777
Copy link
Member Author

paulb777 commented Feb 1, 2024

I addedretry_wait_seconds and it successfully self deflaked. It would be nice to add a longer time only on nightly runs for the git connectivity flakes.

@paulb777 paulb777 merged commit 8ec4afc into main Feb 1, 2024
54 checks passed
@paulb777 paulb777 deleted the pb-gha-retry branch February 1, 2024 22:04
@firebase firebase locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants