Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Fix typos: XCode -> Xcode #12294

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[NFC] Fix typos: XCode -> Xcode #12294

merged 1 commit into from
Jan 17, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 17, 2024 •
edited
Loading 

git grep --name-only XCode | xargs sed -i '' "s/XCode/Xcode/g"

#no-changelog

@ncooke3 ncooke3 enabled auto-merge (squash) January 17, 2024 17:24
@ncooke3 ncooke3 merged commit 641e6f8 into main Jan 17, 2024
64 checks passed
@ncooke3 ncooke3 deleted the nc/typos branch January 17, 2024 18:08
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.17% (0e9589c) to 88.17% (df559c6) by +0.00%.

    FilenameBase (0e9589c)Merge (df559c6)Diff
    leveldb_key.cc98.14%98.63%+0.49%
    leveldb_mutation_queue.cc92.42%93.56%+1.14%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    ordered_code.cc94.39%93.90%-0.49%
    write_stream.cc94.37%91.55%-2.82%

  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.81% (0e9589c) to 94.71% (df559c6) by -0.10%.

    FilenameBase (0e9589c)Merge (df559c6)Diff
    FPRClient.m95.28%94.49%-0.79%
    FPRGaugeManager.m97.39%95.42%-1.96%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qgAli1lUSA.html

@firebase firebase locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: firestore api: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard