Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Update CHANGELOG.md #12286

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[Firestore] Update CHANGELOG.md #12286

merged 1 commit into from
Jan 16, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 16, 2024

Follow-up work to #12279 after the decision to switch the warning to an error.

#no-changelog

@ncooke3 ncooke3 requested a review from andrewheard January 16, 2024 22:28
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.16% (b7a5bc5) to 88.18% (e14fe0d) by +0.02%.

    FilenameBase (b7a5bc5)Merge (e14fe0d)Diff
    ordered_code.cc93.90%94.39%+0.49%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/23bj7rlCEe.html

@ncooke3 ncooke3 merged commit 3f6ac9f into main Jan 16, 2024
49 checks passed
@ncooke3 ncooke3 deleted the nc/changelog-patch branch January 16, 2024 23:27
@firebase firebase locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard