Firestore: Remove unnecessary brace initialization in call to AlphaNum #12281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… see cl/597458773)
Coverage Report 1Affected Products
Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary brace initialization in call to AlphaNum. This does not change any functionality, but merely improves the code quality to use AlphaNum in the intended manner.
Brace-initialized calls to AlphaNum are unsupported, and are misused as function parameters, which cause problems when attempts are made to modify the implementations of functions such as StrCat. While this particular usage (inside a base-class constructor call) itself isn't problematic, it does blocking brace initialization in the future in Google's internal source code repository, hence this change. Googlers see cl/598865604 for details.
#no-changelog