Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Use foundation API instead of C API #12264

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Firestore: Use foundation API instead of C API #12264

merged 1 commit into from
Jan 12, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 11, 2024 •
edited
Loading

This PR was followed up by #12315

@dconeybe dconeybe self-assigned this Jan 11, 2024
@dconeybe dconeybe changed the title Firestore: Replace calls to stat() with NSFileManager Firestore: Use foundation API instead of C API Jan 11, 2024
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Jan 11, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.15% (4ae0c5d) to 88.17% (ecf2b13) by +0.01%.

    FilenameBase (4ae0c5d)Merge (ecf2b13)Diff
    filesystem_apple.mm83.78%88.24%+4.45%
    filesystem_posix.cc81.82%80.43%-1.38%
    leveldb_opener.cc77.54%78.99%+1.45%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1hV3w8iNvr.html

@dconeybe dconeybe marked this pull request as ready for review January 11, 2024 23:02
@dconeybe dconeybe requested a review from wu-hui January 11, 2024 23:02
@dconeybe dconeybe merged commit 6225805 into main Jan 12, 2024
50 checks passed
@dconeybe dconeybe deleted the dconeybe/NoStat branch January 12, 2024 01:35
@dconeybe dconeybe mentioned this pull request Jan 24, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @ncooke3