Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Small Count API documentation improvements #12254

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Firestore: Small Count API documentation improvements #12254

merged 4 commits into from
Jan 10, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 9, 2024

Apply the feedback to the count and aggregation API documentation as suggested in firebase/firebase-js-sdk#6608. This is a port of firebase/firebase-js-sdk#7933.

#no-changelog

@dconeybe dconeybe self-assigned this Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Apple API Diff Report

Commit: fde91ba
Last updated: Wed Jan 10 10:04 PST 2024
View workflow logs & download artifacts

[BUILD ERROR] FirebaseFirestore

@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (3e147e8)Merge (baea71e)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JvdFh88U7T.html

@dconeybe dconeybe mentioned this pull request Jan 9, 2024
Merged
@google-oss-bot
Copy link

google-oss-bot commented Jan 9, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.17% (b880ec8) to 88.10% (fde91ba) by -0.07%.

    FilenameBase (b880ec8)Merge (fde91ba)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.43%98.82%+0.39%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ktjAB5O2JP.html

@dconeybe dconeybe marked this pull request as ready for review January 10, 2024 16:34
@dconeybe dconeybe merged commit 4ae0c5d into main Jan 10, 2024
50 checks passed
@dconeybe dconeybe deleted the dconeybe/CountApiDocTweaks branch January 10, 2024 21:21
@firebase firebase locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @tom-andersen