Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth-swift] TODO review and ObjC Sample delete #12240

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[auth-swift] TODO review and ObjC Sample delete #12240

merged 2 commits into from
Jan 4, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jan 4, 2024

Review TODO's in the Auth Swift implementation of the library (not tests)

  • Address some of them
  • Delete already resolved ones
  • Mark existing TODO's from the ObjC implementation with ObjC

Delete the Objective C sample since it depends on no-longer visible internal methods. The ObjC sample from the main branch can be used a reference for future Swift Sample app development.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 requested a review from andrewheard January 4, 2024 19:41
@paulb777 paulb777 merged commit 7902ab4 into auth-swift Jan 4, 2024
47 checks passed
@paulb777 paulb777 deleted the pb-todo-review branch January 4, 2024 21:48
@firebase firebase locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @andrewheard