Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth-swift] Add 'FirebaseAuth*' to iOS 13+ scheme using SPM #12233

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 3, 2024

The Xcode project file changes come from configuration done to the settings highlighted in green.

Screenshot 2024-01-03 at 10 37 42 AM

@ncooke3 ncooke3 requested a review from paulb777 January 3, 2024 15:38
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 3, 2024

I also moved over FirebaseAuthCombine since FirebaseAuth will require iOS 13+.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ncooke3 ncooke3 merged commit 0d4ce1c into pb-client-app-update Jan 3, 2024
24 checks passed
@ncooke3 ncooke3 deleted the nc-client-app-update branch January 3, 2024 16:13
@paulb777
Copy link
Member

paulb777 commented Jan 3, 2024

It turns out my problem was having the firebase-ios-sdk package open in another window, so the dependencies didn't show up when I got to that screen.

@firebase firebase locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants