Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollouts]Add a rollout metadata constant #12209

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

ddnan
Copy link
Contributor

@ddnan ddnan commented Dec 19, 2023

My first pull request in RC!

Add a string constant as key of rollout metadata in fetch response

Note: this change will merge to our feature branch not master
#no-changelog

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ddnan ddnan requested a review from karenyz December 19, 2023 22:07
@karenyz karenyz marked this pull request as ready for review December 19, 2023 22:09
@ddnan
Copy link
Contributor Author

ddnan commented Dec 19, 2023

Reference in setup_check.sh has been changed from master to main in #12203
Maybe we should merge those changed to featureRollouts branch.

@ddnan ddnan changed the title [Draft]Add a rollout metadata constant [Rollouts]Add a rollout metadata constant Dec 19, 2023
@ddnan ddnan merged commit 8a20d26 into featureRollouts Dec 19, 2023
66 of 68 checks passed
@ddnan ddnan deleted the ddn-rollout branch December 19, 2023 23:27
@firebase firebase locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants