Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging: Adopt NSSecureCoding for internal classes #12110

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Messaging: Adopt NSSecureCoding for internal classes #12110

merged 2 commits into from
Nov 16, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 16, 2023 •
edited
Loading

Fix #12075 for Messaging.

Passed unit tests before and after updating them. Fixed one of the unit tests that has always been broken.

@google-oss-bot
Copy link

google-oss-bot commented Nov 16, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.53% (b891c92) to 60.44% (1a73556) by -0.09%.

    FilenameBase (b891c92)Merge (1a73556)Diff
    FIRMessagingAPNSInfo.m86.96%87.76%+0.80%
    FIRMessagingTokenInfo.m77.27%73.91%-3.36%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EoNXEj499t.html

@paulb777 paulb777 merged commit c26a54a into master Nov 16, 2023
71 checks passed
@paulb777 paulb777 deleted the pb-secure-coding branch November 16, 2023 22:42
@paulb777 paulb777 mentioned this pull request Dec 6, 2023
Closed
@firebase firebase locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
api: messaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: NSSecureCoding support
4 participants
@paulb777 @google-oss-bot @ncooke3 @aashishpatil-g