Prepare Firestore for use as a static library #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and shouldn't
Make the targets independent in Firestore/Example/Podfile and add a workaround to deduplicate dependencies.
mikelehen
approved these changes
May 2, 2018
paulb777
approved these changes
May 3, 2018
There was a problem hiding this comment.
Thanks for working through all of this @wilhuff!
This can be addressed separately:
Seeing one Firestore build warning in default build with Xcode 9.3 - /Users/paulbeusterien/pure/firebase-ios-sdk/Firestore/Source/Remote/FSTRemoteEvent.mm:47:17: warning: method definition for 'filterUpdatesUsingExistingKeys:' not found [-Wincomplete-implementation]
@implementation FSTTargetMapping
^
In file included from /Users/paulbeusterien/pure/firebase-ios-sdk/Firestore/Source/Remote/FSTRemoteEvent.mm:17:
/Users/paulbeusterien/pure/firebase-ios-sdk/Firestore/Example/Pods/../../../Firestore/Source/Remote/FSTRemoteEvent.h:52:1: note: method 'filterUpdatesUsingExistingKeys:' declared here
- (void)filterUpdatesUsingExistingKeys:(FSTDocumentKeySet *)existingKeys;
^
1 warning generated.
Firestore/Example/Podfile
Outdated
| @@ -11,26 +11,54 @@ pod 'FirebaseFirestore', :path => '../../' | |||
|
|
|||
| target 'Firestore_Example_iOS' do | |||
| platform :ios, '8.0' | |||
| end | |||
There was a problem hiding this comment.
A comment here to look below for construction of the dependent targets could be helpful.
wilhuff
added a commit
that referenced
this pull request
May 3, 2018
method definition for 'filterUpdatesUsingExistingKeys:' not found There are no abstract methods in Objective-C so the base class needs an implementation. It can throw like the other abstract-like methods do or just provide a default behavior. I've opted for the latter here.
wilhuff
added a commit
that referenced
this pull request
May 3, 2018
paulb777
added a commit
that referenced
this pull request
May 14, 2018
* Update travis to use CocoaPods 1.5.2 * CODE_SIGNING_ALLOWED=YES * Remove workaround and iPhone 8 * Remove #1210 static library Podfile workaround * Add -all_load to Firestore Example so all C++ is available for tests
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
…1218) method definition for 'filterUpdatesUsingExistingKeys:' not found There are no abstract methods in Objective-C so the base class needs an implementation.
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Remove spurious dependencies on other project targets in the integration tests * Integration tests don't depend on OCMock ... and shouldn't * Integration tests don't directly depend upon leveldb either * Flatten Firestore example Podfile Make the targets independent in Firestore/Example/Podfile and add a workaround to deduplicate dependencies. * Project file output from running pod update
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Update travis to use CocoaPods 1.5.2 * CODE_SIGNING_ALLOWED=YES * Remove workaround and iPhone 8 * Remove firebase#1210 static library Podfile workaround * Add -all_load to Firestore Example so all C++ is available for tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prepares for building/testing Firestore as a static library. It fixes the errors encountered putting together #1056, but does not yet add any direct support for building the static version of Firestore--that will come separately.
Concretely, this change:
Further discussion of the underlying issue is here CocoaPods/CocoaPods#7155