Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebaseCore CI on Xcode 15 #12032

Merged
merged 4 commits into from
Oct 31, 2023
Merged

FirebaseCore CI on Xcode 15 #12032

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67b68ba
FirebaseCore CI on Xcode 15
paulb777 Oct 31, 2023
0dfa8f3
visionOS and disable macos pll tests
paulb777 Oct 31, 2023
05299a5
visionos
paulb777 Oct 31, 2023
ed4b609
Try exclude
paulb777 Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions .github/workflows/core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,17 @@ jobs:
pod-lib-lint:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
runs-on: macos-12
strategy:
matrix:
target: [ios, tvos, macos]
# TODO: macos tests are blocked by https://github.com/erikdoe/ocmock/pull/532
target: [ios, tvos, macos --skip-tests]
os: [macos-12, macos-13]
include:
- os: macos-12
xcode: Xcode_14.2
- os: macos-13
xcode: Xcode_15.0.1
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: ruby/setup-ruby@v1
Expand All @@ -33,10 +40,19 @@ jobs:
spm:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
runs-on: macos-12
strategy:
matrix:
target: [iOS, tvOS, macOS, catalyst, watchOS]
os: [macos-12, macos-13]
include:
- os: macos-12
xcode: Xcode_14.2
- os: macos-13
xcode: Xcode_15.0.1
- target: visionOS
os: macos-13
xcode: Xcode_15.0.1
paulb777 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
Expand All @@ -51,7 +67,7 @@ jobs:
# Don't run on private repo unless it is a PR.
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'

runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v3
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
Expand All @@ -65,9 +81,9 @@ jobs:

core-cron-only:
# Don't run on private repo.
if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'
# if: github.event_name == 'schedule' && github.repository == 'Firebase/firebase-ios-sdk'

runs-on: macos-12
runs-on: macos-13
strategy:
matrix:
target: [ios, tvos, macos]
Expand Down
8 changes: 8 additions & 0 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ platform can be one of:
tvOS
watchOS
catalyst
visionOS
method can be one of:
xcodebuild (default)
cmake
Expand Down Expand Up @@ -170,6 +171,9 @@ tvos_flags=(
watchos_flags=(
-destination 'platform=watchOS Simulator,name=Apple Watch Series 7 (45mm)'
)
visionos_flags=(
-destination 'platform=visionOS Simulator'
)
catalyst_flags=(
ARCHS=x86_64 VALID_ARCHS=x86_64 SUPPORTS_MACCATALYST=YES -sdk macosx
-destination platform="macOS,variant=Mac Catalyst,arch=x86_64" TARGETED_DEVICE_FAMILY=2
Expand Down Expand Up @@ -206,6 +210,10 @@ case "$platform" in
xcb_flags=("${watchos_flags[@]}")
;;

visionOS)
xcb_flags=("${visionos_flags[@]}")
;;

catalyst)
xcb_flags=("${catalyst_flags[@]}")
;;
Expand Down