[Passkey #7] FIRUser startPasskeyEnrollmentWithName:completion: & finalizePasskeyEnrollmentWithPlatformCredential:completion: implementation #11991
Conversation
Generated by 🚫 Danger |
Apple API Diff ReportCommit: 60876c1 FirebaseAuthClasses[ADDED] FIRPasskeyInfo[ADDED] FIRPasskeyInfoSwift:
+ class PasskeyInfo : NSObject
+ var name : String { get }
+ var credentialID : String { get }
Objective-C:
+ @interface FIRPasskeyInfo : NSObject
+ @property ( nonatomic , readonly ) NSString * _Nonnull name ;
+ @property ( nonatomic , readonly ) NSString * _Nonnull credentialID ;FIRUser[ADDED] enrolledPasskeysSwift:
+ var enrolledPasskeys : [ PasskeyInfo ] { get }
Objective-C:
+ @property ( nonatomic , readonly ) API_UNAVAILABLE ( watchos ) NSArray < FIRPasskeyInfo *> * enrolledPasskeys ;[ADDED] -startPasskeyEnrollmentWithName:completion:Swift:
+ func startPasskeyEnrollment ( with name : String ?) async throws -> ASAuthorizationPlatformPublicKeyCredentialRegistrationRequest
Objective-C:
+ - ( void ) startPasskeyEnrollmentWithName :( nullable NSString * ) name completion : ( nullable void ( ^ )( ASAuthorizationPlatformPublicKeyCredentialRegistrationRequest * _Nullable , NSError * _Nullable )) completion ;[ADDED] -finalizePasskeyEnrollmentWithPlatformCredential:completion:Swift:
+ func finalizePasskeyEnrollment ( with platformCredential : ASAuthorizationPlatformPublicKeyCredentialRegistration ) async throws -> AuthDataResult
Objective-C:
+ - ( void ) finalizePasskeyEnrollmentWithPlatformCredential : ( nonnull ASAuthorizationPlatformPublicKeyCredentialRegistration * ) platformCredential completion : ( nullable void ( ^ )( FIRAuthDataResult * _Nullable , NSError * _Nullable )) completion ; |
There was a problem hiding this comment.
Why do we need this file?
There was a problem hiding this comment.
I needed to use the initWithDictionary method that was inherited from . However I don't want to expose this in the public data type.
| #import "FIRUserInfo.h" | ||
|
|
||
| @class FIRAuthTokenResult; | ||
| @class FIRPhoneAuthCredential; | ||
| @class FIRUserProfileChangeRequest; | ||
| @class FIRUserMetadata; | ||
| @protocol FIRAuthUIDelegate; | ||
| #if TARGET_OS_IOS || TARGET_OS_TV || TARGET_OS_OSX || TARGET_OS_MACCATALYST |
There was a problem hiding this comment.
Should TARGET_OS_VISION be included here or excluded via availability in the header?
There was a problem hiding this comment.
visionOS is supported on 1.0+ beta, do you think we should include it here?
There was a problem hiding this comment.
Yes, we're striving to provide build support for Firebase for visionOS and community supported functionality.
Note other examples of the usage of TARGET_OS_VISION so that it builds both on Xcode 14 and Xcode 15.
There was a problem hiding this comment.
Thank you Paul. Will address this in a different PR for all occurance. tracking ticket b/307595519
Future PR
Test cases that need "expires_in" changes in first for finalizePasskeyEnrollmentWithPlatformCredential:completion: on both provided passkey name and not provided passkey name.