-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auth] Revert reCAPTCHA integration PRs #11617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple API Diff ReportCommit: bd07e9f FirebaseAuthEnumerationsFIRAuthErrorCode[REMOVED] FIRAuthErrorCodeInvalidRecaptchaActionSwift:
- case invalidRecaptchaAction = 17203
Objective-C:
- FIRAuthErrorCodeInvalidRecaptchaAction = 17203 [REMOVED] FIRAuthErrorCodeInvalidRecaptchaVersionSwift:
- case invalidRecaptchaVersion = 17206
Objective-C:
- FIRAuthErrorCodeInvalidRecaptchaVersion = 17206 [MODIFIED] FIRAuthErrorCodeMissingClientIdentifierSwift:
+ case missingClientIdentifier = 17993
- case missingClientIdentifier = 17093
Objective-C:
+ FIRAuthErrorCodeMissingClientIdentifier = 17993
- FIRAuthErrorCodeMissingClientIdentifier = 17093 [REMOVED] FIRAuthErrorCodeMissingRecaptchaTokenSwift:
- case missingRecaptchaToken = 17201
Objective-C:
- FIRAuthErrorCodeMissingRecaptchaToken = 17201 [REMOVED] FIRAuthErrorCodeInvalidReqTypeSwift:
- case invalidReqType = 17207
Objective-C:
- FIRAuthErrorCodeInvalidReqType = 17207 [REMOVED] FIRAuthErrorCodeRecaptchaSDKNotLinkedSwift:
- case recaptchaSDKNotLinked = 17208
Objective-C:
- FIRAuthErrorCodeRecaptchaSDKNotLinked = 17208 [REMOVED] FIRAuthErrorCodeMissingRecaptchaVersionSwift:
- case missingRecaptchaVersion = 17205
Objective-C:
- FIRAuthErrorCodeMissingRecaptchaVersion = 17205 [REMOVED] FIRAuthErrorCodeRecaptchaNotEnabledSwift:
- case recaptchaNotEnabled = 17200
Objective-C:
- FIRAuthErrorCodeRecaptchaNotEnabled = 17200 [REMOVED] FIRAuthErrorCodeMissingClientTypeSwift:
- case missingClientType = 17204
Objective-C:
- FIRAuthErrorCodeMissingClientType = 17204 [REMOVED] FIRAuthErrorCodeInvalidRecaptchaTokenSwift:
- case invalidRecaptchaToken = 17202
Objective-C:
- FIRAuthErrorCodeInvalidRecaptchaToken = 17202 |
paulb777
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
renkelvin
approved these changes
Jul 26, 2023
Size Report 1Affected ProductsTest Logs |
Coverage Report 1Affected Products
Test Logs |
renkelvin
pushed a commit
that referenced
this pull request
Aug 15, 2023
This reverts commit 24c9cba.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting these due to an issue with the zip build -- pulling these changes out of the 10.13.0 release.