Skip to content

Commit

Permalink
Build integration tests with Xcode 15.1
Browse files Browse the repository at this point in the history
  • Loading branch information
paulb777 committed Feb 5, 2024
1 parent 31663e8 commit 7ca39d8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/auth.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

env:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
runs-on: macos-12
runs-on: macos-13
steps:
- uses: actions/checkout@v4
- uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
Expand All @@ -85,7 +85,8 @@ jobs:
FirebaseAuth/Tests/SampleSwift/Sample.entitlements "$plist_secret"
scripts/decrypt_gha_secret.sh scripts/gha-encrypted/AuthSample/Credentials.swift.gpg \
FirebaseAuth/Tests/SampleSwift/SwiftApiTests/Credentials.swift "$plist_secret"
- name: Xcode
run: sudo xcode-select -s /Applications/Xcode_15.1.app/Contents/Developer
- name: BuildAndTest # can be replaced with pod lib lint with CocoaPods 1.10
run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/build.sh Auth iOS)

Expand Down
14 changes: 7 additions & 7 deletions FirebaseAuth/Sources/Swift/User/User.swift
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ extension User: NSSecureCoding {}
#if os(iOS)
/// Updates the phone number for the user. On success, the cached user profile data is updated.
///
/// Invoked asynchronously on the main thread in the future.
/// Invoked asynchronously on the main thread in the future.
///
/// This method is available on iOS only.
///
Expand All @@ -220,10 +220,9 @@ extension User: NSSecureCoding {}
/// sensitive operation that requires a recent login from the user. This error indicates
/// the user has not signed in recently enough. To resolve, reauthenticate the user by
/// calling `reauthenticate(with:)`.
/// - Parameter phoneNumberCredential: The new phone number credential corresponding to the
/// - Parameter credential: The new phone number credential corresponding to the
/// phone number to be added to the Firebase account, if a phone number is already linked to the
/// account
/// this new phone number will replace it.
/// account this new phone number will replace it.
/// - Parameter completion: Optionally; the block invoked when the user profile change has
/// finished.
@objc(updatePhoneNumberCredential:completion:)
Expand Down Expand Up @@ -558,8 +557,9 @@ extension User: NSSecureCoding {}
/// Retrieves the Firebase authentication token, possibly refreshing it if it has expired.
///
/// The authentication token will be refreshed (by making a network request) if it has
/// expired, or if `forceRefresh` is `true`.
/// - Parameter forceRefresh: Forces a token refresh. Useful if the token becomes invalid for some
/// expired, or if `forcingRefresh` is `true`.
/// - Parameter forcingRefresh: Forces a token refresh. Useful if the token becomes invalid for
/// some
/// reason other than an expiration.
/// - Parameter completion: Optionally; the block invoked when the token is available. Invoked
/// asynchronously on the main thread in the future.
Expand Down Expand Up @@ -1452,7 +1452,7 @@ extension User: NSSecureCoding {}
/// Updates the phone number for the user. On success, the cached user profile data is updated.
///
/// Invoked asynchronously on the global work queue in the future.
/// - Parameter phoneAuthCredential: The new phone number credential corresponding to the phone
/// - Parameter credential: The new phone number credential corresponding to the phone
/// number to be added to the Firebase account. If a phone number is already linked to the
/// account, this new phone number will replace it.
/// - Parameter isLinkOperation: Boolean value indicating whether or not this is a link
Expand Down

0 comments on commit 7ca39d8

Please sign in to comment.