Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Vendor Plugin #6640

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Refactor Vendor Plugin #6640

merged 9 commits into from
Jan 24, 2025

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jan 21, 2025

Per b/391351857,

This refactors the VendorPlugin and VendorTask to be more compliant with the gradle cache and configuration avoidance. It also adds proper task logging and documentation to both the task and the plugin.

This PR also fixes the following:

  • b/391352175 -> Rename plugin Util files to Extensions

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.3

@daymxn daymxn enabled auto-merge (squash) January 21, 2025 16:39
Copy link
Contributor

github-actions bot commented Jan 21, 2025

plugins test results

37 tests   37 ✅  2m 18s ⏱️
 8 suites   0 💤
 8 files     0 ❌

Results for commit 9be5a54.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Test Results

 1 034 files  ±0   1 034 suites  ±0   34m 37s ⏱️ +25s
 5 888 tests ±0   5 866 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 839 runs  ±0  11 795 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 9be5a54. ± Comparison against base commit 377edcc.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 21, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 21, 2025

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (377edcc) to 50.16% (89e8435) by -0.04%.

    FilenameBase (377edcc)Merge (89e8435)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
  • firebase-storage

    Overall coverage changed from 83.92% (377edcc) to 83.96% (89e8435) by +0.04%.

    FilenameBase (377edcc)Merge (89e8435)Diff
    StreamDownloadTask.java88.41%88.89%+0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gDHGUlZ7Xo.html

@daymxn daymxn requested a review from rlazo January 23, 2025 19:02
@daymxn daymxn merged commit 0ce193f into main Jan 24, 2025
261 of 264 checks passed
@daymxn daymxn deleted the daymon-refactor-vendor-plugin branch January 24, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants