Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all SDKs dependencies to use the version catalog #6584

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Move all SDKs dependencies to use the version catalog #6584

merged 7 commits into from
Dec 10, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Dec 9, 2024

The only dependencies not moved are the ones against other Firebase libraries. These will be updated during releases.

@rlazo
Move all SDKs dependencies to use the version catalog
95ac822 
The only dependencies not moved are the ones against other Firebase
libraries.  These will be updated during releases.
@rlazo rlazo requested review from daymxn and dconeybe and removed request for daymxn December 9, 2024 20:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@dconeybe
Copy link
Contributor

dconeybe commented Dec 9, 2024

Totally optional, and if you want to do this feel free to open a new PR for it... Consider also moving dependencies from the top-level build.gradle file into libs.versions.toml.

firebase-android-sdk/build.gradle

Lines 34 to 38 in b164139

classpath 'com.google.protobuf:protobuf-gradle-plugin:0.9.4'
classpath 'net.ltgt.gradle:gradle-errorprone-plugin:3.1.0'
classpath 'com.google.gms:google-services:4.3.15'
classpath 'com.google.firebase:firebase-appdistribution-gradle:5.0.0'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.5'

IMO doing so makes the version numbers more explicit at the usage points, rather than relying on an implicit default version number set in the top-level build.gradle file.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Test Results

 1 036 files  +   974   1 036 suites  +974   34m 42s ⏱️ + 33m 36s
 5 873 tests + 5 332   5 851 ✅ + 5 311  22 💤 +21  0 ❌ ±0 
11 831 runs  +10 749  11 787 ✅ +10 707  44 💤 +42  0 ❌ ±0 

Results for commit 128fcb8. ± Comparison against base commit f93c0a0.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 9, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (f93c0a0) to 75.99% (0cbb34e) by ?.

    68 individual files with coverage change

    FilenameBase (f93c0a0)Merge (0cbb34e)Diff
    AabUpdater.java?98.36%?
    AabUpdater_Factory.java?0.00%?
    ApkInstaller.java?100.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?92.63%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?100.00%?
    AppDistributionReleaseInternal.java?100.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_BindContentResolverFactory.java?0.00%?
    AppIconSource.java?84.62%?
    AppIconSource_Factory.java?100.00%?
    AutoValue_AppDistributionReleaseImpl.java?65.45%?
    AutoValue_AppDistributionReleaseInternal.java?71.58%?
    AutoValue_ImageUtils_ImageSize.java?35.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?29.41%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?54.17%?
    AutoValue_UpdateProgressImpl.java?65.96%?
    DaggerAppDistroComponent.java?80.56%?
    DevModeDetector.java?9.09%?
    DevModeDetector_Factory.java?100.00%?
    ErrorMessages.java?0.00%?
    FeedbackActivity.java?3.39%?
    FeedbackActivity_MembersInjector.java?0.00%?
    FeedbackSender.java?84.48%?
    FeedbackSender_Factory.java?0.00%?
    FeedbackTrigger.java?61.54%?
    FirebaseAppDistributionExceptions.java?80.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?89.89%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?91.49%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?88.89%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?95.83%?
    FirebaseAppDistributionTesterApiClient.java?88.78%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?50.00%?
    HttpsUrlConnectionFactory_Factory.java?100.00%?
    ImageUtils.java?100.00%?
    InstallActivity.java?2.67%?
    LogWrapper.java?86.67%?
    NewReleaseFetcher.java?86.67%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?42.86%?
    ReleaseIdentifier.java?91.78%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?83.33%?
    ScreenshotTaker.java?36.17%?
    ScreenshotTaker_Factory.java?0.00%?
    SequentialReference.java?100.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?100.00%?
    SignInStorage_Factory.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity.java?0.00%?
    TakeScreenshotAndStartFeedbackActivity_MembersInjector.java?0.00%?
    TaskCache.java?100.00%?
    TaskCompletionSourceCache.java?72.41%?
    TaskUtils.java?77.50%?
    TesterApiDisabledErrorDetails.java?93.75%?
    TesterApiHttpClient.java?90.09%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?95.45%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?100.00%?
    UpdateTaskCache.java?91.30%?
    UpdateTaskImpl.java?76.32%?

  • firebase-firestore

    Overall coverage changed from 45.73% (f93c0a0) to 45.73% (0cbb34e) by -0.00%.

    FilenameBase (f93c0a0)Merge (0cbb34e)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.22%94.44%-2.78%

  • firebase-inappmessaging

    Overall coverage changed from ? (f93c0a0) to 39.03% (0cbb34e) by ?.

    148 individual files with coverage change

    FilenameBase (f93c0a0)Merge (0cbb34e)Diff
    AbtIntegrationHelper.java?60.87%?
    AbtIntegrationHelper_Factory.java?0.00%?
    Action.java?76.47%?
    Analytics.java?0.00%?
    AnalyticsConstants.java?0.00%?
    AnalyticsEventsManager.java?85.19%?
    AnalyticsEventsModule.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsConnectorEventsFactory.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsEventsManagerFactory.java?0.00%?
    AnalyticsListener.java?0.00%?
    ApiClient.java?100.00%?
    ApiClientModule.java?0.00%?
    ApiClientModule_ProvidesApiClientFactory.java?0.00%?
    ApiClientModule_ProvidesDataCollectionHelperFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseAppFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseInstallationsFactory.java?0.00%?
    ApiClientModule_ProvidesSharedPreferencesUtilsFactory.java?0.00%?
    ApiClientModule_ProvidesTestDeviceHelperFactory.java?0.00%?
    AppComponent.java?0.00%?
    AppForeground.java?0.00%?
    ApplicationModule.java?0.00%?
    ApplicationModule_DeveloperListenerManagerFactory.java?0.00%?
    ApplicationModule_ProvidesApplicationFactory.java?0.00%?
    AppMeasurementModule.java?0.00%?
    AppMeasurementModule_ProvidesAnalyticsConnectorFactory.java?0.00%?
    AppMeasurementModule_ProvidesSubsriberFactory.java?0.00%?
    AutoValue_InstallationIdResult.java?33.33%?
    AutoValue_RateLimit.java?44.68%?
    BannerMessage.java?75.00%?
    Button.java?61.76%?
    CampaignAnalytics.java?33.22%?
    CampaignAnalyticsOrBuilder.java?0.00%?
    CampaignCache.java?0.00%?
    CampaignCacheClient.java?88.00%?
    CampaignCacheClient_Factory.java?0.00%?
    CampaignImpression.java?38.96%?
    CampaignImpressionList.java?39.25%?
    CampaignImpressionListOrBuilder.java?0.00%?
    CampaignImpressionOrBuilder.java?0.00%?
    CampaignMetadata.java?100.00%?
    CampaignProto.java?27.23%?
    CardMessage.java?78.48%?
    ClientAppInfo.java?35.79%?
    ClientAppInfoOrBuilder.java?0.00%?
    Clock.java?0.00%?
    CommonTypesProto.java?9.87%?
    DaggerAppComponent.java?0.00%?
    DaggerUniversalComponent.java?0.00%?
    DataCollectionHelper.java?87.50%?
    DataCollectionHelper_Factory.java?0.00%?
    DeveloperListenerManager.java?100.00%?
    DismissType.java?82.61%?
    DisplayCallbacksFactory.java?100.00%?
    DisplayCallbacksFactory_Factory.java?0.00%?
    DisplayCallbacksImpl.java?93.46%?
    EventType.java?76.19%?
    ExecutorsModule.java?0.00%?
    ExecutorsModule_ProvidesBackgroundExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesBlockingExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesLightWeightExecutorFactory.java?0.00%?
    ExperimentPayloadProto.java?6.05%?
    FetchEligibleCampaignsRequest.java?32.98%?
    FetchEligibleCampaignsRequestOrBuilder.java?0.00%?
    FetchEligibleCampaignsResponse.java?42.86%?
    FetchEligibleCampaignsResponseOrBuilder.java?0.00%?
    FetchErrorReason.java?52.17%?
    FiamAnalyticsConnectorListener.java?100.00%?
    FiamFetchService.java?0.00%?
    FirebaseAppScope.java?0.00%?
    FirebaseInAppMessaging.java?80.60%?
    FirebaseInAppMessagingCampaignAnalyticsProto.java?0.00%?
    FirebaseInAppMessagingClickListener.java?0.00%?
    FirebaseInAppMessagingContextualTrigger.java?0.00%?
    FirebaseInAppMessagingDismissListener.java?0.00%?
    FirebaseInAppMessagingDisplay.java?0.00%?
    FirebaseInAppMessagingDisplayCallbacks.java?100.00%?
    FirebaseInAppMessagingDisplayErrorListener.java?0.00%?
    FirebaseInAppMessagingImpressionListener.java?0.00%?
    FirebaseInAppMessagingRegistrar.java?0.00%?
    FirebaseInAppMessaging_Factory.java?0.00%?
    ForegroundFlowableModule.java?0.00%?
    ForegroundFlowableModule_ProvidesAppForegroundEventStreamFactory.java?0.00%?
    ForegroundNotifier.java?76.00%?
    GrpcChannelModule.java?0.00%?
    GrpcChannelModule_ProvidesGrpcChannelFactory.java?0.00%?
    GrpcChannelModule_ProvidesServiceHostFactory.java?0.00%?
    GrpcClient.java?100.00%?
    GrpcClientModule.java?0.00%?
    GrpcClientModule_ProvidesApiKeyHeadersFactory.java?0.00%?
    GrpcClientModule_ProvidesInAppMessagingSdkServingStubFactory.java?0.00%?
    GrpcClient_Factory.java?0.00%?
    ImageData.java?71.43%?
    ImageOnlyMessage.java?75.86%?
    ImpressionStorageClient.java?100.00%?
    ImpressionStorageClient_Factory.java?0.00%?
    ImpressionStore.java?0.00%?
    InAppMessage.java?24.24%?
    InAppMessageStreamManager.java?91.40%?
    InAppMessageStreamManager_Factory.java?0.00%?
    InAppMessaging.kt?0.00%?
    InAppMessagingSdkServingGrpc.java?45.95%?
    InstallationIdResult.java?100.00%?
    Logging.java?0.00%?
    MessagesProto.java?36.03%?
    MessageType.java?100.00%?
    MetricsLoggerClient.java?94.29%?
    ModalMessage.java?74.07%?
    ProgramaticContextualTriggers.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggersFactory.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggerStreamFactory.java?0.00%?
    ProgrammaticTrigger.java?0.00%?
    ProtoMarshallerClient.java?91.40%?
    ProtoMarshallerClient_Factory.java?0.00%?
    ProtoStorageClient.java?100.00%?
    ProtoStorageClientModule.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForCampaignFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForImpressionStoreFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForLimiterStoreFactory.java?0.00%?
    ProviderInstaller.java?37.50%?
    ProviderInstaller_Factory.java?0.00%?
    ProxyAnalyticsConnector.java?67.95%?
    RateLimit.java?0.00%?
    RateLimiterClient.java?100.00%?
    RateLimiterClient_Factory.java?0.00%?
    RateLimitModule.java?0.00%?
    RateLimitModule_ProvidesAppForegroundRateLimitFactory.java?0.00%?
    RateLimitProto.java?52.69%?
    RenderErrorReason.java?82.61%?
    SchedulerModule.java?0.00%?
    SchedulerModule_ProvidesComputeSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesIOSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesMainThreadSchedulerFactory.java?0.00%?
    Schedulers.java?87.50%?
    Schedulers_Factory.java?0.00%?
    SharedPreferencesUtils.java?40.35%?
    SharedPreferencesUtils_Factory.java?0.00%?
    SystemClock.java?100.00%?
    SystemClockModule.java?0.00%?
    SystemClockModule_ProvidesSystemClockModuleFactory.java?0.00%?
    SystemClock_Factory.java?0.00%?
    TestDeviceHelper.java?100.00%?
    TestDeviceHelper_Factory.java?0.00%?
    Text.java?67.74%?
    TransportClientModule.java?0.00%?
    TransportClientModule_ProvidesMetricsLoggerClientFactory.java?0.00%?
    TriggeredInAppMessage.java?100.00%?
    UniversalComponent.java?0.00%?

  • firebase-installations

    Overall coverage changed from 58.68% (f93c0a0) to 58.17% (0cbb34e) by -0.51%.

    FilenameBase (f93c0a0)Merge (0cbb34e)Diff
    AutoValue_PersistedInstallationEntry.java61.18%56.98%-4.20%
    AutoValue_TokenResult.java45.65%42.22%-3.43%

  • firebase-messaging

    Overall coverage changed from 84.12% (f93c0a0) to 84.00% (0cbb34e) by -0.11%.

    FilenameBase (f93c0a0)Merge (0cbb34e)Diff
    FirebaseMessaging.java76.40%75.60%-0.80%
    Metadata.java41.27%36.51%-4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.38% (f93c0a0) to 82.11% (0cbb34e) by -1.28%.

    FilenameBase (f93c0a0)Merge (0cbb34e)Diff
    AutoValue_FirebaseMlLogEvent.java58.18%56.60%-1.58%
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java66.67%58.33%-8.33%
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent.java65.82%56.96%-8.86%
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions.java62.96%60.00%-2.96%
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions_ModelInfo.java64.58%56.25%-8.33%
    AutoValue_FirebaseMlLogEvent_SystemInfo.java63.38%54.93%-8.45%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hIdCrU7Ojm.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 10, 2024 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    aar230 kB230 kB+56 B (+0.0%)
    apk (aggressive)1.08 MB1.23 MB+152 kB (+14.0%)
    apk (release)7.01 MB7.84 MB+822 kB (+11.7%)

  • firebase-firestore

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    aar1.45 MB1.45 MB+11 B (+0.0%)
    apk (release)11.4 MB11.4 MB+4 B (+0.0%)

  • firebase-firestore-ktx

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (release)11.4 MB11.4 MB+4 B (+0.0%)

  • firebase-inappmessaging

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    aar461 kB461 kB-21 B (-0.0%)
    apk (aggressive)1.05 MB1.05 MB+8 B (+0.0%)
    apk (release)11.7 MB11.7 MB-12 B (-0.0%)

  • firebase-inappmessaging-display

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)2.02 MB2.24 MB+220 kB (+10.9%)
    apk (release)14.0 MB15.9 MB+1.84 MB (+13.2%)

  • firebase-inappmessaging-display-ktx

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)2.02 MB2.24 MB+220 kB (+10.9%)
    apk (release)14.0 MB15.9 MB+1.84 MB (+13.2%)

  • firebase-inappmessaging-ktx

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)1.05 MB1.05 MB+8 B (+0.0%)
    apk (release)11.7 MB11.7 MB-16 B (-0.0%)

  • firebase-installations

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    aar57.7 kB57.6 kB-109 B (-0.2%)

  • firebase-installations-interop

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    aar6.64 kB6.63 kB-17 B (-0.3%)
    apk (aggressive)73.1 kB70.9 kB-2.21 kB (-3.0%)
    apk (release)1.40 MB1.27 MB-135 kB (-9.7%)

  • firebase-messaging

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)578 kB578 kB-228 B (-0.0%)
    apk (release)5.30 MB5.31 MB+3.23 kB (+0.1%)

  • firebase-messaging-directboot

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)578 kB578 kB-232 B (-0.0%)
    apk (release)5.31 MB5.31 MB+3.23 kB (+0.1%)

  • firebase-messaging-ktx

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)578 kB578 kB-232 B (-0.0%)
    apk (release)5.31 MB5.31 MB+3.23 kB (+0.1%)

  • firebase-ml-modeldownloader

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    aar126 kB125 kB-353 B (-0.3%)
    apk (release)4.78 MB4.78 MB-212 B (-0.0%)

  • firebase-ml-modeldownloader-ktx

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (release)4.78 MB4.78 MB-212 B (-0.0%)

  • firebase-perf

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)1.57 MB1.63 MB+64.3 kB (+4.1%)
    apk (release)9.10 MB10.1 MB+978 kB (+10.8%)

  • firebase-perf-ktx

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)1.57 MB1.63 MB+64.3 kB (+4.1%)
    apk (release)9.10 MB10.1 MB+978 kB (+10.8%)

  • firebase-storage

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)399 kB398 kB-296 B (-0.1%)
    apk (release)5.04 MB5.04 MB+3.08 kB (+0.1%)

  • firebase-storage-ktx

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)399 kB399 kB-296 B (-0.1%)
    apk (release)5.04 MB5.04 MB+3.08 kB (+0.1%)

  • firebase-vertexai

    TypeBase (f93c0a0)Merge (0cbb34e)Diff
    apk (aggressive)1.14 MB1.09 MB-43.7 kB (-3.8%)
    apk (release)9.29 MB9.15 MB-144 kB (-1.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zuqcXZCIez.html

@rlazo rlazo merged commit 2b072d9 into main Dec 10, 2024
262 of 263 checks passed
@rlazo rlazo deleted the rl.move.to.catalog branch December 10, 2024 19:37
@rlazo
Copy link
Collaborator Author

rlazo commented Dec 10, 2024

Totally optional, and if you want to do this feel free to open a new PR for it... Consider also moving dependencies from the top-level build.gradle file into libs.versions.toml.

firebase-android-sdk/build.gradle

Lines 34 to 38 in b164139

classpath 'com.google.protobuf:protobuf-gradle-plugin:0.9.4'
classpath 'net.ltgt.gradle:gradle-errorprone-plugin:3.1.0'
classpath 'com.google.gms:google-services:4.3.15'
classpath 'com.google.firebase:firebase-appdistribution-gradle:5.0.0'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.5'

IMO doing so makes the version numbers more explicit at the usage points, rather than relying on an implicit default version number set in the top-level build.gradle file.

Yes, will do in a follow up PR.

@firebase firebase locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @dconeybe