Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SDKs to version catalog #6389

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Oct 17, 2024

Per b/374135906,

This migrates all our SDKs to use the version catalog where appropriate.

This is ONLY done when the version we use in the version catalog is the same version the SDK was using, so this should be a NOP change. There may also be other dependencies that could be moved to the version catalog, but research needs to be performed for that- which is out of scope of this PR.

NO_RELEASE_CHANGE

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.0

Copy link
Contributor

github-actions bot commented Oct 17, 2024

buildSrc Test Results

37 tests   37 ✅  1m 10s ⏱️
 8 suites   0 💤
 8 files     0 ❌

Results for commit bdfefa1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Test Results

 1 022 files  ±0   1 022 suites  ±0   36m 8s ⏱️ -5s
 5 809 tests ±0   5 787 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 703 runs  ±0  11 659 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit bdfefa1. ± Comparison against base commit a00c310.

♻️ This comment has been updated with latest results.

@daymxn daymxn merged commit d96507b into main Oct 24, 2024
261 of 262 checks passed
@daymxn daymxn deleted the daymon-migrate-to-version-catalog branch October 24, 2024 17:29
@firebase firebase locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants