Fix release config for config-interop #5539

rlazo · 2023-11-09T23:00:22Z

No description provided.

github-actions · 2023-11-09T23:00:38Z

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-config-interop

google-oss-bot · 2023-11-09T23:01:08Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2023-11-09T23:05:12Z

Coverage Report ¹

Affected Products

No changes between base commit (58f456f) and merge commit (c5087af).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/0SUfJNw09Y.html

github-actions · 2023-11-09T23:06:40Z

Unit Test Results

  44 files +    2   44 suites +2 1m 22s ⏱️ -7s
329 tests +149 329 ✔️ +149 0 💤 ±0 0 ❌ ±0
658 runs +298 658 ✔️ +298 0 💤 ±0 0 ❌ ±0

Results for commit 45cda7a. ± Comparison against base commit 58f456f.

This pull request removes 180 and adds 329 tests. Note that renamed tests count towards both.

com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectswith307_shouldCorrectlyFollowTheRedirectViaPost
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendResponseTimesOut_shouldReturnTransientError
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

google-oss-bot · 2023-11-09T23:13:35Z

Size Report ¹

Affected Products

firebase-config-interop
Type Base (58f456f) Merge (c5087af) Diff
aar 10.4 kB 10.4 kB +3 B (+0.0%)
apk (release) 598 kB 598 kB +4 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/FfYLJMJxTw.html

google-oss-bot · 2023-11-09T23:24:38Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (58f456f) and the CI merge commit (c5087af)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 58f456f: https://storage.googleapis.com/firebase-sdk-metric-reports/lfT1EFUsWs/index.html
- c5087af: https://storage.googleapis.com/firebase-sdk-metric-reports/3rgSQTLz3z/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`58f456f`	`c5087af`	Diff	Significant (?)
p10	9.67 ±3 ms	11.2 ±3 ms	+1.48 ms (+15.3%)	NO
p25	10.5 ±3 ms	11.8 ±3 ms	+1.36 ms (+13.0%)	NO
p50	11.4 ±3 ms	13.0 ±3 ms	+1.57 ms (+13.7%)	NO
p75	12.7 ±3 ms	14.3 ±4 ms	+1.54 ms (+12.1%)	NO
p90	14.2 ±3 ms	16.1 ±4 ms	+1.90 ms (+13.4%)	NO

20 test runs in comparison

Commit	Test Runs
`58f456f`	2023-11-09_17:13:00.761896_IpDr 2023-11-09_17:13:00.761928_SVRz 2023-11-09_17:13:00.761940_BeGY 2023-11-09_17:13:00.761949_NgQD 2023-11-09_17:13:00.761956_fRfl 2023-11-09_17:13:00.761963_gepG 2023-11-09_17:13:00.761975_IWCM 2023-11-09_17:13:00.761982_kvPx 2023-11-09_17:13:00.761989_gDss 2023-11-09_17:13:00.761996_rgMa
`c5087af`	2023-11-09_23:11:32.521573_bpCS 2023-11-09_23:11:32.521608_AwJM 2023-11-09_23:11:32.521620_ghIQ 2023-11-09_23:11:32.521628_VTrg 2023-11-09_23:11:32.521638_oXyw 2023-11-09_23:11:32.521648_IIXV 2023-11-09_23:11:32.521656_gSZE 2023-11-09_23:11:32.521665_Kjzh 2023-11-09_23:11:32.521671_PtoY 2023-11-09_23:11:32.521675_mXWP

redfin-30

Percentile	`58f456f`	`c5087af`	Diff	Significant (?)
p10	14.8 ±6 ms	12.9 ±4 ms	-1.88 ms (-12.7%)	NO
p25	15.6 ±7 ms	13.7 ±5 ms	-1.94 ms (-12.4%)	NO
p50	16.8 ±8 ms	14.7 ±6 ms	-2.09 ms (-12.4%)	NO
p75	18.4 ±8 ms	16.2 ±7 ms	-2.18 ms (-11.9%)	NO
p90	20.9 ±9 ms	18.6 ±9 ms	-2.29 ms (-11.0%)	NO

20 test runs in comparison

Commit	Test Runs
`58f456f`	2023-11-09_17:13:00.761896_IpDr 2023-11-09_17:13:00.761928_SVRz 2023-11-09_17:13:00.761940_BeGY 2023-11-09_17:13:00.761949_NgQD 2023-11-09_17:13:00.761956_fRfl 2023-11-09_17:13:00.761963_gepG 2023-11-09_17:13:00.761975_IWCM 2023-11-09_17:13:00.761982_kvPx 2023-11-09_17:13:00.761989_gDss 2023-11-09_17:13:00.761996_rgMa
`c5087af`	2023-11-09_23:11:32.521573_bpCS 2023-11-09_23:11:32.521608_AwJM 2023-11-09_23:11:32.521620_ghIQ 2023-11-09_23:11:32.521628_VTrg 2023-11-09_23:11:32.521638_oXyw 2023-11-09_23:11:32.521648_IIXV 2023-11-09_23:11:32.521656_gSZE 2023-11-09_23:11:32.521665_Kjzh 2023-11-09_23:11:32.521671_PtoY 2023-11-09_23:11:32.521675_mXWP

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`58f456f`	`c5087af`	Diff	Significant (?)
p10	245 ±382 μs	254 ±348 μs	+8.71 μs (+3.6%)	NO
p25	258 ±401 μs	270 ±365 μs	+12.2 μs (+4.7%)	NO
p50	280 ±422 μs	297 ±399 μs	+17.0 μs (+6.1%)	NO
p75	337 ±482 μs	356 ±452 μs	+19.8 μs (+5.9%)	NO
p90	428 ±581 μs	433 ±526 μs	+5.13 μs (+1.2%)	NO

20 test runs in comparison

Commit	Test Runs
`58f456f`	2023-11-09_17:13:00.761896_IpDr 2023-11-09_17:13:00.761928_SVRz 2023-11-09_17:13:00.761940_BeGY 2023-11-09_17:13:00.761949_NgQD 2023-11-09_17:13:00.761956_fRfl 2023-11-09_17:13:00.761963_gepG 2023-11-09_17:13:00.761975_IWCM 2023-11-09_17:13:00.761982_kvPx 2023-11-09_17:13:00.761989_gDss 2023-11-09_17:13:00.761996_rgMa
`c5087af`	2023-11-09_23:11:32.521573_bpCS 2023-11-09_23:11:32.521608_AwJM 2023-11-09_23:11:32.521620_ghIQ 2023-11-09_23:11:32.521628_VTrg 2023-11-09_23:11:32.521638_oXyw 2023-11-09_23:11:32.521648_IIXV 2023-11-09_23:11:32.521656_gSZE 2023-11-09_23:11:32.521665_Kjzh 2023-11-09_23:11:32.521671_PtoY 2023-11-09_23:11:32.521675_mXWP

redfin-30

Percentile	`58f456f`	`c5087af`	Diff	Significant (?)
p10	358 ±452 μs	458 ±510 μs	+100 μs (+28.0%)	NO
p25	421 ±541 μs	535 ±608 μs	+113 μs (+26.9%)	NO
p50	497 ±647 μs	650 ±783 μs	+153 μs (+30.8%)	NO
p75	575 ±772 μs	801 ±1002 μs	+227 μs (+39.4%)	NO
p90	695 ±972 μs	1.01 ±1 ms	+311 μs (+44.8%)	NO

20 test runs in comparison

Commit	Test Runs
`58f456f`	2023-11-09_17:13:00.761896_IpDr 2023-11-09_17:13:00.761928_SVRz 2023-11-09_17:13:00.761940_BeGY 2023-11-09_17:13:00.761949_NgQD 2023-11-09_17:13:00.761956_fRfl 2023-11-09_17:13:00.761963_gepG 2023-11-09_17:13:00.761975_IWCM 2023-11-09_17:13:00.761982_kvPx 2023-11-09_17:13:00.761989_gDss 2023-11-09_17:13:00.761996_rgMa
`c5087af`	2023-11-09_23:11:32.521573_bpCS 2023-11-09_23:11:32.521608_AwJM 2023-11-09_23:11:32.521620_ghIQ 2023-11-09_23:11:32.521628_VTrg 2023-11-09_23:11:32.521638_oXyw 2023-11-09_23:11:32.521648_IIXV 2023-11-09_23:11:32.521656_gSZE 2023-11-09_23:11:32.521665_Kjzh 2023-11-09_23:11:32.521671_PtoY 2023-11-09_23:11:32.521675_mXWP

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`58f456f`	`c5087af`	Diff	Significant (?)
p10	204 ±4 ms	209 ±3 ms	+4.76 ms (+2.3%)	NO
p25	211 ±5 ms	215 ±2 ms	+4.07 ms (+1.9%)	NO
p50	219 ±5 ms	222 ±2 ms	+3.05 ms (+1.4%)	NO
p75	228 ±6 ms	230 ±2 ms	+2.79 ms (+1.2%)	NO
p90	235 ±6 ms	241 ±3 ms	+6.47 ms (+2.8%)	NO

20 test runs in comparison

Commit	Test Runs
`58f456f`	2023-11-09_17:13:00.761896_IpDr 2023-11-09_17:13:00.761928_SVRz 2023-11-09_17:13:00.761940_BeGY 2023-11-09_17:13:00.761949_NgQD 2023-11-09_17:13:00.761956_fRfl 2023-11-09_17:13:00.761963_gepG 2023-11-09_17:13:00.761975_IWCM 2023-11-09_17:13:00.761982_kvPx 2023-11-09_17:13:00.761989_gDss 2023-11-09_17:13:00.761996_rgMa
`c5087af`	2023-11-09_23:11:32.521573_bpCS 2023-11-09_23:11:32.521608_AwJM 2023-11-09_23:11:32.521620_ghIQ 2023-11-09_23:11:32.521628_VTrg 2023-11-09_23:11:32.521638_oXyw 2023-11-09_23:11:32.521648_IIXV 2023-11-09_23:11:32.521656_gSZE 2023-11-09_23:11:32.521665_Kjzh 2023-11-09_23:11:32.521671_PtoY 2023-11-09_23:11:32.521675_mXWP

redfin-30

Percentile	`58f456f`	`c5087af`	Diff	Significant (?)
p10	248 ±5 ms	271 ±3 ms	+22.6 ms (+9.1%)	MAYBE
p25	254 ±5 ms	277 ±4 ms	+22.8 ms (+9.0%)	MAYBE
p50	262 ±5 ms	286 ±4 ms	+23.2 ms (+8.9%)	MAYBE
p75	271 ±6 ms	295 ±5 ms	+24.1 ms (+8.9%)	MAYBE
p90	283 ±7 ms	312 ±11 ms	+29.0 ms (+10.2%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`58f456f`	2023-11-09_17:13:00.761896_IpDr 2023-11-09_17:13:00.761928_SVRz 2023-11-09_17:13:00.761940_BeGY 2023-11-09_17:13:00.761949_NgQD 2023-11-09_17:13:00.761956_fRfl 2023-11-09_17:13:00.761963_gepG 2023-11-09_17:13:00.761975_IWCM 2023-11-09_17:13:00.761982_kvPx 2023-11-09_17:13:00.761989_gDss 2023-11-09_17:13:00.761996_rgMa
`c5087af`	2023-11-09_23:11:32.521573_bpCS 2023-11-09_23:11:32.521608_AwJM 2023-11-09_23:11:32.521620_ghIQ 2023-11-09_23:11:32.521628_VTrg 2023-11-09_23:11:32.521638_oXyw 2023-11-09_23:11:32.521648_IIXV 2023-11-09_23:11:32.521656_gSZE 2023-11-09_23:11:32.521665_Kjzh 2023-11-09_23:11:32.521671_PtoY 2023-11-09_23:11:32.521675_mXWP

https://storage.googleapis.com/firebase-sdk-metric-reports/neQT3XbpjF/index.html

Cherrypick

Fix release config for config-interop

45cda7a

rlazo requested a review from mrober November 9, 2023 23:00

google-oss-bot added the size/XS label Nov 9, 2023

rlazo requested a review from davidmotson November 9, 2023 23:05

davidmotson approved these changes Nov 9, 2023

View reviewed changes

mrober approved these changes Nov 10, 2023

View reviewed changes

rlazo merged commit ab05c99 into master Nov 10, 2023
27 checks passed

rlazo deleted the rl.config.interop.init branch November 10, 2023 15:19

rlazo added a commit that referenced this pull request Nov 10, 2023

Fix release config for config-interop (#5539)

fb88e17

rlazo added a commit that referenced this pull request Nov 10, 2023

Fix release config for config-interop (#5539) (#5541)

016e91f

Cherrypick

firebase locked and limited conversation to collaborators Dec 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix release config for config-interop #5539

Fix release config for config-interop #5539

rlazo commented Nov 9, 2023

github-actions bot commented Nov 9, 2023 •

edited

Loading

google-oss-bot commented Nov 9, 2023

google-oss-bot commented Nov 9, 2023

github-actions bot commented Nov 9, 2023

google-oss-bot commented Nov 9, 2023

`firebase-config-interop`

google-oss-bot commented Nov 9, 2023

`fire-cls`

`fire-rc`

`timeToInitialDisplay`

Fix release config for config-interop #5539

Fix release config for config-interop #5539

Conversation

rlazo commented Nov 9, 2023

github-actions bot commented Nov 9, 2023 • edited Loading

Release note changes

google-oss-bot commented Nov 9, 2023

google-oss-bot commented Nov 9, 2023

Coverage Report 1

Affected Products

Test Logs

github-actions bot commented Nov 9, 2023

Unit Test Results

google-oss-bot commented Nov 9, 2023

Size Report 1

Affected Products

firebase-config-interop

Test Logs

google-oss-bot commented Nov 9, 2023

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

timeToInitialDisplay

github-actions bot commented Nov 9, 2023 •

edited

Loading

Coverage Report ¹

Size Report ¹

`firebase-config-interop`

Startup Time Report ¹

`fire-cls`

`fire-rc`

`timeToInitialDisplay`