Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump transport versions #5535

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Bump transport versions #5535

merged 1 commit into from
Nov 9, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 9, 2023

Post release update

NO_RELEASE_CHANGE

Post release update
Copy link
Contributor

github-actions bot commented Nov 9, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Unit Test Results

  42 files   -    237    42 suites   - 237   1m 52s ⏱️ - 9m 19s
180 tests  - 1 740  180 ✔️  - 1 740  0 💤 ±0  0 ±0 
360 runs   - 3 441  360 ✔️  - 3 441  0 💤 ±0  0 ±0 

Results for commit 4386acd. ± Comparison against base commit 3a4cc9a.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-datatransport

    TypeBase (3a4cc9a)Merge (77ac33e)Diff
    apk (release)1.35 MB1.35 MB+8 B (+0.0%)
  • transport-api

    TypeBase (3a4cc9a)Merge (77ac33e)Diff
    aar8.46 kB8.47 kB+4 B (+0.0%)
    apk (release)15.5 kB15.5 kB+4 B (+0.0%)
  • transport-backend-cct

    TypeBase (3a4cc9a)Merge (77ac33e)Diff
    aar67.3 kB67.3 kB-2 B (-0.0%)
  • transport-runtime

    TypeBase (3a4cc9a)Merge (77ac33e)Diff
    aar160 kB160 kB+10 B (+0.0%)
    apk (release)79.7 kB79.7 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1B8LFXBdZC.html

@rlazo rlazo requested a review from emilypgoogle November 9, 2023 16:41
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-transport

    DeviceStatisticsDistributions
    oriole-32
    Percentile3a4cc9a77ac33eDiffSignificant (?)
    p10208 ±394 μs222 ±620 μs+13.3 μs (+6.4%)NO
    p25222 ±421 μs229 ±637 μs+6.61 μs (+3.0%)NO
    p50243 ±452 μs243 ±670 μs+342 ns (+0.1%)NO
    p75306 ±565 μs281 ±766 μs-24.7 μs (-8.1%)NO
    p90354 ±646 μs358 ±953 μs+3.58 μs (+1.0%)NO

    20 test runs in comparison
    CommitTest Runs
    3a4cc9a
    • 2023-11-08_22:00:05.374546_CIvA
    • 2023-11-08_22:00:05.374576_NpRh
    • 2023-11-08_22:00:05.374589_yDXm
    • 2023-11-08_22:00:05.374599_fjgN
    • 2023-11-08_22:00:05.374606_UeOJ
    • 2023-11-08_22:00:05.374614_Aejp
    • 2023-11-08_22:00:05.374621_Dbzv
    • 2023-11-08_22:00:05.374628_Zezx
    • 2023-11-08_22:00:05.374634_tPPi
    • 2023-11-08_22:00:05.374641_eRcB
    77ac33e
    • 2023-11-09_16:27:36.619434_oGFW
    • 2023-11-09_16:27:36.619470_KMOj
    • 2023-11-09_16:27:36.619482_avpl
    • 2023-11-09_16:27:36.619492_hDqZ
    • 2023-11-09_16:27:36.619500_iYUi
    • 2023-11-09_16:27:36.619514_cSKh
    • 2023-11-09_16:27:36.619522_rdjr
    • 2023-11-09_16:27:36.619528_jZjB
    • 2023-11-09_16:27:36.619535_RqUI
    • 2023-11-09_16:27:36.619542_Pose
    redfin-30
    Percentile3a4cc9a77ac33eDiffSignificant (?)
    p10775 ±1862 μs853 ±1458 μs+78.5 μs (+10.1%)NO
    p25820 ±1978 μs909 ±1519 μs+89.9 μs (+11.0%)NO
    p50876 ±2120 μs1.02 ±2 ms+149 μs (+17.0%)NO
    p75945 ±2278 μs1.21 ±2 ms+264 μs (+27.9%)NO
    p901.15 ±3 ms1.56 ±2 ms+408 μs (+35.4%)NO

    20 test runs in comparison
    CommitTest Runs
    3a4cc9a
    • 2023-11-08_22:00:05.374546_CIvA
    • 2023-11-08_22:00:05.374576_NpRh
    • 2023-11-08_22:00:05.374589_yDXm
    • 2023-11-08_22:00:05.374599_fjgN
    • 2023-11-08_22:00:05.374606_UeOJ
    • 2023-11-08_22:00:05.374614_Aejp
    • 2023-11-08_22:00:05.374621_Dbzv
    • 2023-11-08_22:00:05.374628_Zezx
    • 2023-11-08_22:00:05.374634_tPPi
    • 2023-11-08_22:00:05.374641_eRcB
    77ac33e
    • 2023-11-09_16:27:36.619434_oGFW
    • 2023-11-09_16:27:36.619470_KMOj
    • 2023-11-09_16:27:36.619482_avpl
    • 2023-11-09_16:27:36.619492_hDqZ
    • 2023-11-09_16:27:36.619500_iYUi
    • 2023-11-09_16:27:36.619514_cSKh
    • 2023-11-09_16:27:36.619522_rdjr
    • 2023-11-09_16:27:36.619528_jZjB
    • 2023-11-09_16:27:36.619535_RqUI
    • 2023-11-09_16:27:36.619542_Pose
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile3a4cc9a77ac33eDiffSignificant (?)
    p10201 ±4 ms207 ±1 ms+6.01 ms (+3.0%)NO
    p25208 ±5 ms212 ±2 ms+4.89 ms (+2.4%)NO
    p50215 ±5 ms220 ±2 ms+5.08 ms (+2.4%)NO
    p75225 ±4 ms229 ±2 ms+4.36 ms (+1.9%)NO
    p90235 ±5 ms239 ±5 ms+4.30 ms (+1.8%)NO

    20 test runs in comparison
    CommitTest Runs
    3a4cc9a
    • 2023-11-08_22:00:05.374546_CIvA
    • 2023-11-08_22:00:05.374576_NpRh
    • 2023-11-08_22:00:05.374589_yDXm
    • 2023-11-08_22:00:05.374599_fjgN
    • 2023-11-08_22:00:05.374606_UeOJ
    • 2023-11-08_22:00:05.374614_Aejp
    • 2023-11-08_22:00:05.374621_Dbzv
    • 2023-11-08_22:00:05.374628_Zezx
    • 2023-11-08_22:00:05.374634_tPPi
    • 2023-11-08_22:00:05.374641_eRcB
    77ac33e
    • 2023-11-09_16:27:36.619434_oGFW
    • 2023-11-09_16:27:36.619470_KMOj
    • 2023-11-09_16:27:36.619482_avpl
    • 2023-11-09_16:27:36.619492_hDqZ
    • 2023-11-09_16:27:36.619500_iYUi
    • 2023-11-09_16:27:36.619514_cSKh
    • 2023-11-09_16:27:36.619522_rdjr
    • 2023-11-09_16:27:36.619528_jZjB
    • 2023-11-09_16:27:36.619535_RqUI
    • 2023-11-09_16:27:36.619542_Pose
    redfin-30
    Percentile3a4cc9a77ac33eDiffSignificant (?)
    p10247 ±4 ms272 ±7 ms+24.2 ms (+9.8%)MAYBE
    p25253 ±4 ms278 ±8 ms+25.4 ms (+10.0%)MAYBE
    p50260 ±5 ms287 ±9 ms+27.0 ms (+10.4%)MAYBE
    p75269 ±5 ms298 ±9.7 ms+29.4 ms (+10.9%)MAYBE
    p90280 ±6 ms319 ±18 ms+39.2 ms (+14.0%)NO

    20 test runs in comparison
    CommitTest Runs
    3a4cc9a
    • 2023-11-08_22:00:05.374546_CIvA
    • 2023-11-08_22:00:05.374576_NpRh
    • 2023-11-08_22:00:05.374589_yDXm
    • 2023-11-08_22:00:05.374599_fjgN
    • 2023-11-08_22:00:05.374606_UeOJ
    • 2023-11-08_22:00:05.374614_Aejp
    • 2023-11-08_22:00:05.374621_Dbzv
    • 2023-11-08_22:00:05.374628_Zezx
    • 2023-11-08_22:00:05.374634_tPPi
    • 2023-11-08_22:00:05.374641_eRcB
    77ac33e
    • 2023-11-09_16:27:36.619434_oGFW
    • 2023-11-09_16:27:36.619470_KMOj
    • 2023-11-09_16:27:36.619482_avpl
    • 2023-11-09_16:27:36.619492_hDqZ
    • 2023-11-09_16:27:36.619500_iYUi
    • 2023-11-09_16:27:36.619514_cSKh
    • 2023-11-09_16:27:36.619522_rdjr
    • 2023-11-09_16:27:36.619528_jZjB
    • 2023-11-09_16:27:36.619535_RqUI
    • 2023-11-09_16:27:36.619542_Pose

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3HmhBeIZER/index.html

@rlazo rlazo merged commit 58f456f into master Nov 9, 2023
29 checks passed
@rlazo rlazo deleted the rl.transport.bump branch November 9, 2023 17:00
rlazo added a commit that referenced this pull request Nov 9, 2023
Post release update

NO_RELEASE_CHANGE
rlazo added a commit that referenced this pull request Nov 9, 2023
Post release update

NO_RELEASE_CHANGE
@firebase firebase locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants