Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump firebase-datatransport dependencies #5486

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Oct 30, 2023

No description provided.

@rlazo rlazo requested a review from VinayGuthal October 30, 2023 15:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

@github-actions
Copy link
Contributor

Unit Test Results

2 files   -   4  2 suites   - 4   17s ⏱️ -3s
1 tests  - 17  1 ✔️  - 17  0 💤 ±0  0 ±0 
2 runs   - 34  2 ✔️  - 34  0 💤 ±0  0 ±0 

Results for commit c7aa737. ± Comparison against base commit 36b6403.

This pull request removes 18 and adds 1 tests. Note that renamed tests count towards both.
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…
com.google.firebase.datatransport.TransportRegistrationTest ‑ test_componentIsRegisteredAndAvailable

@rlazo rlazo enabled auto-merge (squash) October 30, 2023 15:56
@rlazo rlazo merged commit 3704b6e into master Oct 30, 2023
@rlazo rlazo deleted the rl.bump.datatransport.deps branch October 30, 2023 15:58
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-datatransport

    TypeBase (36b6403)Merge (7005cca)Diff
    apk (aggressive)163 kB164 kB+1.29 kB (+0.8%)
    apk (release)1.35 MB1.35 MB-1.47 kB (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8JWHZRYRrB.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-transport

    DeviceStatisticsDistributions
    oriole-32
    Percentile36b64037005ccaDiffSignificant (?)
    p10485 ±542 μs433 ±681 μs-52.7 μs (-10.9%)NO
    p25516 ±568 μs452 ±709 μs-63.7 μs (-12.3%)NO
    p50632 ±696 μs574 ±895 μs-58.1 μs (-9.2%)NO
    p75802 ±873 μs682 ±1058 μs-120 μs (-15.0%)NO
    p90966 ±1042 μs748 ±1120 μs-218 μs (-22.6%)NO

    20 test runs in comparison
    CommitTest Runs
    36b6403
    • 2023-10-30_14:00:08.551488_jAbc
    • 2023-10-30_14:00:08.552519_Rqnk
    • 2023-10-30_14:00:08.552530_xuKL
    • 2023-10-30_14:00:08.552537_HTGD
    • 2023-10-30_14:00:08.552542_kpsG
    • 2023-10-30_14:00:08.552548_UpAf
    • 2023-10-30_14:00:08.552553_OVvt
    • 2023-10-30_14:00:08.552558_VBzw
    • 2023-10-30_14:00:08.552564_VxZx
    • 2023-10-30_14:00:08.552569_RnTb
    7005cca
    • 2023-10-30_16:02:59.310828_SVJh
    • 2023-10-30_16:02:59.315534_WGSJ
    • 2023-10-30_16:02:59.315547_aNXC
    • 2023-10-30_16:02:59.315554_PLDf
    • 2023-10-30_16:02:59.315560_RoXM
    • 2023-10-30_16:02:59.315566_fyWP
    • 2023-10-30_16:02:59.315572_MLmQ
    • 2023-10-30_16:02:59.315578_WfrA
    • 2023-10-30_16:02:59.315728_JkGq
    • 2023-10-30_16:02:59.315735_DJDa
    redfin-30
    Percentile36b64037005ccaDiffSignificant (?)
    p101.84 ±3 ms831 ±1814 μs-1.01 ms (-55.0%)NO
    p251.98 ±3 ms931 ±1991 μs-1.05 ms (-52.9%)NO
    p502.20 ±3 ms1.06 ±2 ms-1.14 ms (-51.9%)NO
    p752.50 ±4 ms1.28 ±3 ms-1.22 ms (-48.7%)NO
    p903.07 ±5 ms1.61 ±3 ms-1.46 ms (-47.6%)NO

    20 test runs in comparison
    CommitTest Runs
    36b6403
    • 2023-10-30_14:00:08.551488_jAbc
    • 2023-10-30_14:00:08.552519_Rqnk
    • 2023-10-30_14:00:08.552530_xuKL
    • 2023-10-30_14:00:08.552537_HTGD
    • 2023-10-30_14:00:08.552542_kpsG
    • 2023-10-30_14:00:08.552548_UpAf
    • 2023-10-30_14:00:08.552553_OVvt
    • 2023-10-30_14:00:08.552558_VBzw
    • 2023-10-30_14:00:08.552564_VxZx
    • 2023-10-30_14:00:08.552569_RnTb
    7005cca
    • 2023-10-30_16:02:59.310828_SVJh
    • 2023-10-30_16:02:59.315534_WGSJ
    • 2023-10-30_16:02:59.315547_aNXC
    • 2023-10-30_16:02:59.315554_PLDf
    • 2023-10-30_16:02:59.315560_RoXM
    • 2023-10-30_16:02:59.315566_fyWP
    • 2023-10-30_16:02:59.315572_MLmQ
    • 2023-10-30_16:02:59.315578_WfrA
    • 2023-10-30_16:02:59.315728_JkGq
    • 2023-10-30_16:02:59.315735_DJDa
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile36b64037005ccaDiffSignificant (?)
    p10201 ±3 ms205 ±3 ms+3.89 ms (+1.9%)NO
    p25207 ±4 ms211 ±3 ms+4.64 ms (+2.2%)NO
    p50214 ±4 ms220 ±2 ms+5.53 ms (+2.6%)NO
    p75222 ±5 ms228 ±3 ms+6.25 ms (+2.8%)NO
    p90230 ±5 ms242 ±7 ms+12.4 ms (+5.4%)NO

    20 test runs in comparison
    CommitTest Runs
    36b6403
    • 2023-10-30_14:00:08.551488_jAbc
    • 2023-10-30_14:00:08.552519_Rqnk
    • 2023-10-30_14:00:08.552530_xuKL
    • 2023-10-30_14:00:08.552537_HTGD
    • 2023-10-30_14:00:08.552542_kpsG
    • 2023-10-30_14:00:08.552548_UpAf
    • 2023-10-30_14:00:08.552553_OVvt
    • 2023-10-30_14:00:08.552558_VBzw
    • 2023-10-30_14:00:08.552564_VxZx
    • 2023-10-30_14:00:08.552569_RnTb
    7005cca
    • 2023-10-30_16:02:59.310828_SVJh
    • 2023-10-30_16:02:59.315534_WGSJ
    • 2023-10-30_16:02:59.315547_aNXC
    • 2023-10-30_16:02:59.315554_PLDf
    • 2023-10-30_16:02:59.315560_RoXM
    • 2023-10-30_16:02:59.315566_fyWP
    • 2023-10-30_16:02:59.315572_MLmQ
    • 2023-10-30_16:02:59.315578_WfrA
    • 2023-10-30_16:02:59.315728_JkGq
    • 2023-10-30_16:02:59.315735_DJDa
    redfin-30
    Percentile36b64037005ccaDiffSignificant (?)
    p10246 ±4 ms271 ±15 ms+25.2 ms (+10.2%)NO
    p25252 ±5 ms278 ±15 ms+25.5 ms (+10.1%)NO
    p50260 ±5 ms286 ±16 ms+26.5 ms (+10.2%)NO
    p75268 ±6 ms296 ±17 ms+27.7 ms (+10.3%)NO
    p90278 ±6 ms309 ±18 ms+30.5 ms (+11.0%)NO

    20 test runs in comparison
    CommitTest Runs
    36b6403
    • 2023-10-30_14:00:08.551488_jAbc
    • 2023-10-30_14:00:08.552519_Rqnk
    • 2023-10-30_14:00:08.552530_xuKL
    • 2023-10-30_14:00:08.552537_HTGD
    • 2023-10-30_14:00:08.552542_kpsG
    • 2023-10-30_14:00:08.552548_UpAf
    • 2023-10-30_14:00:08.552553_OVvt
    • 2023-10-30_14:00:08.552558_VBzw
    • 2023-10-30_14:00:08.552564_VxZx
    • 2023-10-30_14:00:08.552569_RnTb
    7005cca
    • 2023-10-30_16:02:59.310828_SVJh
    • 2023-10-30_16:02:59.315534_WGSJ
    • 2023-10-30_16:02:59.315547_aNXC
    • 2023-10-30_16:02:59.315554_PLDf
    • 2023-10-30_16:02:59.315560_RoXM
    • 2023-10-30_16:02:59.315566_fyWP
    • 2023-10-30_16:02:59.315572_MLmQ
    • 2023-10-30_16:02:59.315578_WfrA
    • 2023-10-30_16:02:59.315728_JkGq
    • 2023-10-30_16:02:59.315735_DJDa

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QaqUthalxV/index.html

@firebase firebase locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants