Make Sessions throw meaningful message when used with incompatible Perf #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrothfeder
approved these changes
Oct 26, 2023
| } | ||
|
|
||
| @Test | ||
| fun handleSessionUpdate_sendsToAllSubscribersAsLongAsOneIsEnabled() = | ||
| runTest(UnconfinedTestDispatcher()) { | ||
| val client = SessionLifecycleClient(backgroundDispatcher() + coroutineContext) | ||
| val crashlyticsSubscriber = addSubscriber(true, SessionSubscriber.Name.CRASHLYTICS) | ||
| val perfSubscriber = addSubscriber(false, SessionSubscriber.Name.PERFORMANCE) | ||
| val mattSaysHiSubscriber = addSubscriber(false, SessionSubscriber.Name.MATT_SAYS_HI) |
Coverage Report 1Affected Products
Test Logs |
visumickey
approved these changes
Oct 27, 2023
Comment on lines
+45
to
+49
| Incompatible versions of Firebase Perf and Firebase Sessions. | ||
| A safe combination would be: | ||
| firebase-sessions:1.1.0 | ||
| firebase-crashlytics:18.5.0 | ||
| firebase-perf:20.5.0 |
There was a problem hiding this comment.
Do you want the message to reflect that a particular version of a library and above or just leave it at the specified version. Leaving it at a specified version is going to need to update this comment in the near future.
There was a problem hiding this comment.
I put this for now because I don't know what will happen in future versions. I expect we will make it compatible again, so maybe only this version will have this message. If you have a better idea for wording that reflects that we can work on the message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.