Make Logger a normal abstract class

[mrober]

Discussed in #5469 (comment)

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[google-oss-bot]

Coverage Report ¹

Affected Products

No changes between base commit (f6b5ecb) and merge commit (2d79654).

Test Logs

• Base (f6b5ecb): https://github.com/firebase/firebase-android-sdk/actions/runs/6645196426
• Merge (2d79654): https://github.com/firebase/firebase-android-sdk/actions/runs/6654832974

1. https://storage.googleapis.com/firebase-sdk-metric-reports/NzpHFeLJ46.html

[github-actions]

Unit Test Results

  46 files   -    134    46 suites   - 134   1m 43s ⏱️ -36s
  66 tests  - 1 156    66 ✔️  - 1 140  0 💤  - 16  0 ❌ ±0 
148 runs   - 2 320  148 ✔️  - 2 288  0 💤  - 32  0 ❌ ±0 

Results for commit 934dcb9. ± Comparison against base commit f6b5ecb.

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-common

  Type	Base (f6b5ecb)	Merge (2d79654)	Diff
  aar	107 kB	107 kB	-23 B (-0.0%)
  apk (release)	1.65 MB	1.65 MB	+56 B (+0.0%)

Test Logs

• Base (f6b5ecb): https://github.com/firebase/firebase-android-sdk/actions/runs/6645196426
• Merge (2d79654): https://github.com/firebase/firebase-android-sdk/actions/runs/6654832974

1. https://storage.googleapis.com/firebase-sdk-metric-reports/sdaiwNPQ4Q.html

[google-oss-bot]

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

• This report is for comparing the base commit (f6b5ecb) and the CI merge commit (2d79654)
• Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
  • f6b5ecb: https://storage.googleapis.com/firebase-sdk-metric-reports/4au4BRvDr3/index.html
  • 2d79654: https://storage.googleapis.com/firebase-sdk-metric-reports/BJryFul0jR/index.html

Startup Times

• ComponentDiscovery

  Device	Statistics	Distributions
  oriole-32	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 941 ±59 μs 930 ±64 μs -11.0 μs (-1.2%) NO p25 1.02 ±0.07 ms 1.03 ±0.06 ms +2.39 μs (+0.2%) NO p50 1.16 ±0.09 ms 1.15 ±0.07 ms -13.3 μs (-1.1%) NO p75 1.38 ±0.1 ms 1.34 ±0.08 ms -32.5 μs (-2.4%) NO p90 1.68 ±0.08 ms 1.61 ±0.1 ms -65.0 μs (-3.9%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb
  redfin-30	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 861 ±14 μs 878 ±69 μs +17.5 μs (+2.0%) NO p25 901 ±18 μs 919 ±73 μs +18.4 μs (+2.0%) NO p50 976 ±36 μs 991 ±68 μs +14.8 μs (+1.5%) NO p75 1.24 ±0.07 ms 1.28 ±0.08 ms +38.2 μs (+3.1%) NO p90 1.83 ±0.2 ms 1.77 ±0.3 ms -58.0 μs (-3.2%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb

• Firebase

  Device	Statistics	Distributions
  oriole-32	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 6.06 ±0.1 ms 6.07 ±0.2 ms +9.40 μs (+0.2%) NO p25 6.41 ±0.2 ms 6.34 ±0.2 ms -69.6 μs (-1.1%) NO p50 6.91 ±0.2 ms 6.83 ±0.2 ms -74.6 μs (-1.1%) NO p75 7.51 ±0.2 ms 7.48 ±0.3 ms -27.2 μs (-0.4%) NO p90 8.42 ±0.4 ms 8.24 ±0.4 ms -180 μs (-2.1%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb
  redfin-30	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 8.33 ±0.2 ms 8.49 ±0.7 ms +155 μs (+1.9%) NO p25 8.60 ±0.2 ms 8.83 ±0.9 ms +238 μs (+2.8%) NO p50 8.97 ±0.3 ms 9.28 ±1 ms +308 μs (+3.4%) NO p75 9.88 ±0.3 ms 10.1 ±0.9 ms +209 μs (+2.1%) NO p90 11.3 ±0.6 ms 11.6 ±1 ms +245 μs (+2.2%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb

• Runtime

  Device	Statistics	Distributions
  oriole-32	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 4.98 ±0.08 ms 4.96 ±0.1 ms -16.4 μs (-0.3%) NO p25 5.22 ±0.1 ms 5.18 ±0.2 ms -36.0 μs (-0.7%) NO p50 5.61 ±0.1 ms 5.54 ±0.1 ms -64.9 μs (-1.2%) NO p75 6.14 ±0.2 ms 6.08 ±0.2 ms -66.4 μs (-1.1%) NO p90 6.94 ±0.5 ms 6.76 ±0.3 ms -182 μs (-2.6%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb
  redfin-30	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 7.30 ±0.2 ms 7.42 ±0.6 ms +128 μs (+1.7%) NO p25 7.52 ±0.2 ms 7.74 ±0.8 ms +220 μs (+2.9%) NO p50 7.80 ±0.2 ms 8.10 ±0.9 ms +297 μs (+3.8%) NO p75 8.36 ±0.3 ms 8.66 ±0.9 ms +299 μs (+3.6%) NO p90 9.32 ±0.6 ms 9.76 ±1 ms +441 μs (+4.7%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb

• timeToInitialDisplay

  Device	Statistics	Distributions
  oriole-32	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 201 ±3 ms 205 ±4 ms +4.66 ms (+2.3%) NO p25 207 ±3 ms 211 ±3 ms +3.99 ms (+1.9%) NO p50 214 ±4 ms 218 ±4 ms +3.14 ms (+1.5%) NO p75 223 ±4 ms 226 ±5 ms +2.84 ms (+1.3%) NO p90 231 ±4 ms 237 ±7 ms +5.73 ms (+2.5%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb
  redfin-30	Percentile f6b5ecb 2d79654 Diff Significant (?) p10 243 ±4 ms 272 ±16 ms +28.9 ms (+11.9%) NO p25 249 ±3 ms 280 ±21 ms +31.7 ms (+12.7%) NO p50 256 ±3 ms 292 ±31 ms +36.0 ms (+14.1%) NO p75 265 ±4 ms 303 ±35 ms +38.8 ms (+14.7%) NO p90 274 ±5 ms 318 ±37 ms +43.9 ms (+16.0%) NO 20 test runs in comparison Commit Test Runs f6b5ecb 2023-10-25_19:52:19.534770_OROG 2023-10-25_19:52:19.536869_Tlmb 2023-10-25_19:52:19.536887_rMri 2023-10-25_19:52:19.536895_IKvK 2023-10-25_19:52:19.536907_CeRa 2023-10-25_19:52:19.536915_IdTs 2023-10-25_19:52:19.536922_QbLo 2023-10-25_19:52:19.536929_kqUI 2023-10-25_19:52:19.536936_XIgb 2023-10-25_19:52:19.536958_pNGb 2d79654 2023-10-26_13:46:27.134157_HAve 2023-10-26_13:46:27.145520_ybLS 2023-10-26_13:46:27.145536_TCQo 2023-10-26_13:46:27.145543_wszz 2023-10-26_13:46:27.145548_PMVr 2023-10-26_13:46:27.145554_RNEc 2023-10-26_13:46:27.145559_COYa 2023-10-26_13:46:27.145565_WzCO 2023-10-26_13:46:27.145570_Dwuf 2023-10-26_13:46:27.145576_vlnb

1. https://storage.googleapis.com/firebase-sdk-metric-reports/UaXxLJdL3n/index.html