Move sum&avg composite index tests to compositeIndexQueryTest.java #5470

milaGGL · 2023-10-23T17:29:53Z

update terraform to accept collection group index and array membership query
add new composite indexes required for testing
move sum&avg composite index tests to compositeIndexQueryTest.java(some of the field names are changed to be the same with web SDK, so that indexes in terraform are consistent)

github-actions · 2023-10-23T17:30:07Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

google-oss-bot · 2023-10-23T17:38:30Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 44.76% (4998f4f) to 44.75% (0ffee90) by -0.02%.
Filename Base (4998f4f) Merge (0ffee90) Diff
DeleteMutation.java 95.24% 90.48% -4.76%
LruGarbageCollector.java 97.27% 93.64% -3.64%
SetMutation.java 94.44% 97.22% +2.78%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/8x1ksi5Xke.html

github-actions · 2023-10-23T17:40:08Z

Unit Test Results

  180 files +  174   180 suites +174 2m 47s ⏱️ + 2m 24s
1 222 tests +1 204 1 206 ✔️ +1 188 16 💤 +16 0 ❌ ±0
2 468 runs +2 432 2 436 ✔️ +2 400 32 💤 +32 0 ❌ ±0

Results for commit e2b6de2. ± Comparison against base commit 4998f4f.

This pull request removes 18 and adds 1222 tests. Note that renamed tests count towards both.

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-10-23T17:44:45Z

Size Report ¹

Affected Products

No changes between base commit (4998f4f) and merge commit (0ffee90).

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/GF0cMb3B0Z.html

…index-testing

google-oss-bot · 2023-10-23T18:04:01Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (4998f4f) and the CI merge commit (0ffee90)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 4998f4f: https://storage.googleapis.com/firebase-sdk-metric-reports/0lV92feHH9/index.html
- 0ffee90: https://storage.googleapis.com/firebase-sdk-metric-reports/vt3ijOt0GQ/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`4998f4f`	`0ffee90`	Diff	Significant (?)
p10	496 ±50 μs	465 ±32 μs	-31.2 μs (-6.3%)	NO
p25	520 ±57 μs	486 ±38 μs	-33.5 μs (-6.4%)	NO
p50	563 ±78 μs	515 ±50 μs	-47.1 μs (-8.4%)	NO
p75	651 ±130 μs	593 ±128 μs	-57.5 μs (-8.8%)	NO
p90	782 ±211 μs	711 ±270 μs	-71.3 μs (-9.1%)	NO

20 test runs in comparison

Commit	Test Runs
`4998f4f`	2023-10-24_14:39:25.499633_kuQx 2023-10-24_14:39:25.505703_BSgY 2023-10-24_14:39:25.505714_ysOM 2023-10-24_14:39:25.505721_dLRy 2023-10-24_14:39:25.505727_qMnW 2023-10-24_14:39:25.505733_PYpz 2023-10-24_14:39:25.505740_OozP 2023-10-24_14:39:25.505746_ENJX 2023-10-24_14:39:25.505751_KbsE 2023-10-24_14:39:25.505759_YPEu
`0ffee90`	2023-10-25_14:55:15.479603_wezg 2023-10-25_14:55:15.489228_gOGG 2023-10-25_14:55:15.489249_LakU 2023-10-25_14:55:15.489494_WGqB 2023-10-25_14:55:15.489506_NwvW 2023-10-25_14:55:15.489513_ETRw 2023-10-25_14:55:15.489519_apUG 2023-10-25_14:55:15.489525_sQhV 2023-10-25_14:55:15.489801_Qdgx 2023-10-25_14:55:15.489830_eUbO

redfin-30

Percentile	`4998f4f`	`0ffee90`	Diff	Significant (?)
p10	603 ±38 μs	610 ±27 μs	+7.62 μs (+1.3%)	NO
p25	616 ±40 μs	629 ±31 μs	+13.5 μs (+2.2%)	NO
p50	639 ±40 μs	658 ±36 μs	+19.6 μs (+3.1%)	NO
p75	675 ±41 μs	695 ±45 μs	+19.6 μs (+2.9%)	NO
p90	717 ±45 μs	745 ±60 μs	+27.7 μs (+3.9%)	NO

20 test runs in comparison

Commit	Test Runs
`4998f4f`	2023-10-24_14:39:25.499633_kuQx 2023-10-24_14:39:25.505703_BSgY 2023-10-24_14:39:25.505714_ysOM 2023-10-24_14:39:25.505721_dLRy 2023-10-24_14:39:25.505727_qMnW 2023-10-24_14:39:25.505733_PYpz 2023-10-24_14:39:25.505740_OozP 2023-10-24_14:39:25.505746_ENJX 2023-10-24_14:39:25.505751_KbsE 2023-10-24_14:39:25.505759_YPEu
`0ffee90`	2023-10-25_14:55:15.479603_wezg 2023-10-25_14:55:15.489228_gOGG 2023-10-25_14:55:15.489249_LakU 2023-10-25_14:55:15.489494_WGqB 2023-10-25_14:55:15.489506_NwvW 2023-10-25_14:55:15.489513_ETRw 2023-10-25_14:55:15.489519_apUG 2023-10-25_14:55:15.489525_sQhV 2023-10-25_14:55:15.489801_Qdgx 2023-10-25_14:55:15.489830_eUbO

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`4998f4f`	`0ffee90`	Diff	Significant (?)
p10	201 ±3 ms	205 ±3 ms	+4.15 ms (+2.1%)	NO
p25	207 ±4 ms	211 ±3 ms	+4.20 ms (+2.0%)	NO
p50	215 ±5 ms	219 ±3 ms	+4.64 ms (+2.2%)	NO
p75	222 ±5 ms	229 ±3 ms	+6.78 ms (+3.1%)	NO
p90	230 ±6 ms	242 ±7 ms	+12.4 ms (+5.4%)	NO

20 test runs in comparison

Commit	Test Runs
`4998f4f`	2023-10-24_14:39:25.499633_kuQx 2023-10-24_14:39:25.505703_BSgY 2023-10-24_14:39:25.505714_ysOM 2023-10-24_14:39:25.505721_dLRy 2023-10-24_14:39:25.505727_qMnW 2023-10-24_14:39:25.505733_PYpz 2023-10-24_14:39:25.505740_OozP 2023-10-24_14:39:25.505746_ENJX 2023-10-24_14:39:25.505751_KbsE 2023-10-24_14:39:25.505759_YPEu
`0ffee90`	2023-10-25_14:55:15.479603_wezg 2023-10-25_14:55:15.489228_gOGG 2023-10-25_14:55:15.489249_LakU 2023-10-25_14:55:15.489494_WGqB 2023-10-25_14:55:15.489506_NwvW 2023-10-25_14:55:15.489513_ETRw 2023-10-25_14:55:15.489519_apUG 2023-10-25_14:55:15.489525_sQhV 2023-10-25_14:55:15.489801_Qdgx 2023-10-25_14:55:15.489830_eUbO

redfin-30

Percentile	`4998f4f`	`0ffee90`	Diff	Significant (?)
p10	247 ±7 ms	269 ±5 ms	+22.3 ms (+9.1%)	MAYBE
p25	253 ±7 ms	275 ±5 ms	+22.2 ms (+8.8%)	MAYBE
p50	260 ±8 ms	283 ±5 ms	+22.7 ms (+8.7%)	NO
p75	269 ±8 ms	295 ±9 ms	+25.5 ms (+9.5%)	MAYBE
p90	280 ±8 ms	316 ±16 ms	+36.4 ms (+13.0%)	NO

20 test runs in comparison

Commit	Test Runs
`4998f4f`	2023-10-24_14:39:25.499633_kuQx 2023-10-24_14:39:25.505703_BSgY 2023-10-24_14:39:25.505714_ysOM 2023-10-24_14:39:25.505721_dLRy 2023-10-24_14:39:25.505727_qMnW 2023-10-24_14:39:25.505733_PYpz 2023-10-24_14:39:25.505740_OozP 2023-10-24_14:39:25.505746_ENJX 2023-10-24_14:39:25.505751_KbsE 2023-10-24_14:39:25.505759_YPEu
`0ffee90`	2023-10-25_14:55:15.479603_wezg 2023-10-25_14:55:15.489228_gOGG 2023-10-25_14:55:15.489249_LakU 2023-10-25_14:55:15.489494_WGqB 2023-10-25_14:55:15.489506_NwvW 2023-10-25_14:55:15.489513_ETRw 2023-10-25_14:55:15.489519_apUG 2023-10-25_14:55:15.489525_sQhV 2023-10-25_14:55:15.489801_Qdgx 2023-10-25_14:55:15.489830_eUbO

https://storage.googleapis.com/firebase-sdk-metric-reports/PsncQjrobP/index.html

…index-testing

MarkDuckworth

Same questions as web and iOS about batch writes and re-using existing field names. Otherwise, things look good.

move sum& avg tests, add new indexes required

cfa4592

google-oss-bot added the size/L label Oct 23, 2023

milaGGL added the no-changelog label Oct 23, 2023

Merge branch 'master' into mila/move-some-sum&avg-tests-to-composite-…

d3302b2

…index-testing

milaGGL requested review from MarkDuckworth and ehsannas October 23, 2023 20:27

milaGGL assigned MarkDuckworth and ehsannas Oct 23, 2023

milaGGL added 2 commits October 24, 2023 14:18

add a note to re-use existing fields

e3d734c

Merge branch 'master' into mila/move-some-sum&avg-tests-to-composite-…

28385fa

…index-testing

MarkDuckworth reviewed Oct 24, 2023

View reviewed changes

format

e2b6de2

MarkDuckworth approved these changes Oct 25, 2023

View reviewed changes

milaGGL merged commit f6b5ecb into master Oct 25, 2023

milaGGL deleted the mila/move-some-sum&avg-tests-to-composite-index-testing branch October 25, 2023 19:26

firebase locked and limited conversation to collaborators Nov 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move sum&avg composite index tests to compositeIndexQueryTest.java #5470

Move sum&avg composite index tests to compositeIndexQueryTest.java #5470

milaGGL commented Oct 23, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading

google-oss-bot commented Oct 23, 2023 •

edited

Loading

`firebase-firestore`

github-actions bot commented Oct 23, 2023 •

edited

Loading

google-oss-bot commented Oct 23, 2023 •

edited

Loading

google-oss-bot commented Oct 23, 2023 •

edited

Loading

`fire-fst`

`timeToInitialDisplay`

MarkDuckworth left a comment

Move sum&avg composite index tests to compositeIndexQueryTest.java #5470

Move sum&avg composite index tests to compositeIndexQueryTest.java #5470

Conversation

milaGGL commented Oct 23, 2023 • edited Loading

github-actions bot commented Oct 23, 2023 • edited Loading

Release note changes

google-oss-bot commented Oct 23, 2023 • edited Loading

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

github-actions bot commented Oct 23, 2023 • edited Loading

Unit Test Results

google-oss-bot commented Oct 23, 2023 • edited Loading

Size Report 1

Affected Products

Test Logs

google-oss-bot commented Oct 23, 2023 • edited Loading

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

MarkDuckworth left a comment

Choose a reason for hiding this comment

milaGGL commented Oct 23, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading

google-oss-bot commented Oct 23, 2023 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

github-actions bot commented Oct 23, 2023 •

edited

Loading

google-oss-bot commented Oct 23, 2023 •

edited

Loading

Size Report ¹

google-oss-bot commented Oct 23, 2023 •

edited

Loading

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`